Mariadb version change#909
Merged
Merged
Conversation
Signed-off-by: Bonusree <bonusree@appscode.com>
Signed-off-by: Bonusree <bonusree@appscode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAll MariaDB example YAML manifests and guide documentation pages are updated to replace MariaDB versions ChangesMariaDB 11.8.5 Documentation Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
docs/guides/mariadb/backup/stash/logical/standalone/index.md (1)
196-197: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winTask names are inconsistent with the updated
spec.version.The manifest's
spec.versionwas updated to11.8.5(line 57), but the Stash task names shown in kubectl outputs still referencemariadb-backup-10.6.23instead ofmariadb-backup-11.8.5. This creates a mismatch between what the guide claims the manifest version is and what task names would actually be generated by Stash.Compare this to the cluster guide (docs/guides/mariadb/backup/stash/logical/cluster/index.md, lines 213-214), where the task names were correctly updated to
mariadb-backup-11.8.5andmariadb-restore-11.8.5to match the spec.version change.Lines affected:
- Lines 196–197: Task list output
- Line 310: BackupConfiguration verification output
- Line 389: BackupConfiguration paused state output
- Line 462: RestoreSession task.name field
🔧 Proposed fix: Update task names to match new spec.version
Update all
mariadb-backup-10.6.23references tomariadb-backup-11.8.5:Lines 196-197: - mariadb-backup-10.6.23 35s - mariadb-backup-10.6.23 35s + mariadb-backup-11.8.5 35s + mariadb-restore-11.8.5 35s Line 310: - sample-mariadb-backup mariadb-backup-10.6.23 */5 * * * * Ready 11s + sample-mariadb-backup mariadb-backup-11.8.5 */5 * * * * Ready 11s Line 389: - sample-mariadb-backup mariadb-backup-10.6.23 */5 * * * * true Ready 26m + sample-mariadb-backup mariadb-backup-11.8.5 */5 * * * * true Ready 26m Line 462: - task: - name: mariadb-backup-10.6.23 + rules: + - snapshots: [latest] (or update task.name if the YAML structure requires it)Also applies to: 310-310, 389-389, 462-462
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/guides/mariadb/backup/stash/logical/standalone/index.md` around lines 196 - 197, The task names in the kubectl output examples are inconsistent with the updated spec.version. Throughout this documentation file, replace all occurrences of the task name mariadb-backup-10.6.23 with mariadb-backup-11.8.5 to match the spec.version that was updated to 11.8.5. This includes all four locations mentioned: the task list output around lines 196-197, the BackupConfiguration verification output at line 310, the BackupConfiguration paused state output at line 389, and the RestoreSession task.name field at line 462.docs/guides/mariadb/initialization/git-sync.md (1)
83-95: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winMalformed server version string in git-sync example output.
Line 95 shows a server version string with a mixed version identifier:
10.5.23-MariaDB-1:11.8.5+.... The primary version prefix should be updated to11.8.5to match the spec version (line 55) and the kubectl output (line 83).Update line 95 to show the correct version format consistent with other examples in the PR.
🔧 Proposed fix
-Server version: 10.5.23-MariaDB-1:11.8.5+maria~ubu2004 mariadb.org binary distribution +Server version: 11.8.5-MariaDB-1:11.8.5+maria~ubu2004 mariadb.org binary distribution🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/guides/mariadb/initialization/git-sync.md` around lines 83 - 95, The server version string in the MariaDB monitor welcome output section displays a malformed mixed version identifier "10.5.23-MariaDB-1:11.8.5+maria~ubu2004" that is inconsistent with the MariaDB version "11.8.5" shown in both the kubectl output (line 83) and the spec configuration (line 55). Update this version string in the MySQL welcome message output to correctly show "11.8.5-MariaDB" as the primary version identifier to maintain consistency across all version references in the documentation.docs/guides/mariadb/configuration/using-config-file/index.md (1)
99-119: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winYAML manifest example in documentation still references old version.
The YAML block at lines 100–119 shows
spec.version: "10.5.23", but the actual manifest filemd-custom.yaml(line 7) has been updated to11.8.5. The subsequent output examples (lines 132, 147) correctly show version11.8.5, creating a disconnect between the source example and expected output.Update line 106 to match the actual manifest file and ensure documentation consistency.
🔧 Proposed fix
spec: - version: "10.5.23" + version: "11.8.5" configuration:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/guides/mariadb/configuration/using-config-file/index.md` around lines 99 - 119, Update the MariaDB YAML manifest example to maintain consistency with the actual manifest file and subsequent output examples. In the YAML block defining the MariaDB resource, locate the spec.version field which currently specifies "10.5.23" and change it to "11.8.5" to match both the md-custom.yaml source manifest file and the output examples shown later in the documentation.docs/guides/mariadb/concepts/mariadb-version/index.md (1)
44-92: 🎯 Functional Correctness | 🟠 MajorUpdate all version fields in the MariaDBVersion example to be consistent with version 11.8.5.
The shown MariaDBVersion example has three mismatched version fields:
metadata.name→11.8.5✓spec.db.image→11.8.5-focal✓spec.version→10.5.23✗spec.stash.addon.backupTask.name→mariadb-backup-10.6.23✗spec.stash.addon.restoreTask.name→mariadb-restore-10.6.23✗According to your documentation,
spec.versionmust match the actual database version inspec.db.image. The stash addon task names are version-specific and pattern-matched across other examples in the documentation (e.g.,mariadb-backup-11.8.5for MariaDB 11.8.5).Update line 92 (
spec.version) from10.5.23to11.8.5, and update lines 83 and 85 (stash addon task names) tomariadb-backup-11.8.5andmariadb-restore-11.8.5respectively.📝 Proposed fix
stash: addon: backupTask: - name: mariadb-backup-10.6.23 + name: mariadb-backup-11.8.5 restoreTask: - name: mariadb-restore-10.6.23 + name: mariadb-restore-11.8.5 ui: - name: phpmyadmin version: v2024.4.27 updateConstraints: allowlist: - '> 10.5.23, <= 11.5.2' - version: 10.5.23 + version: 11.8.5🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/guides/mariadb/concepts/mariadb-version/index.md` around lines 44 - 92, The MariaDBVersion example has inconsistent version references that should all align with 11.8.5. Update the spec.version field from 10.5.23 to 11.8.5 to match the metadata.name and spec.db.image version. Additionally, update the spec.stash.addon.backupTask.name from mariadb-backup-10.6.23 to mariadb-backup-11.8.5 and update the spec.stash.addon.restoreTask.name from mariadb-restore-10.6.23 to mariadb-restore-11.8.5 to ensure all version-specific task names are consistent with the target MariaDB version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/guides/mariadb/custom-rbac/using-custom-rbac/index.md`:
- Around line 230-236: The MariaDB log output contains an inconsistent version
reference in the entrypoint message. In the second entrypoint message line
showing "Entrypoint script for MySQL Server 1:10.5.23+maria~focal started",
replace the version string `10.5.23` with `11.8.5` to match the version
specified in the spec and shown in all other output lines (the final version
string and the first entrypoint message). This will ensure all version
references in the log block are consistent at version 11.8.5.
In `@docs/guides/mariadb/private-registry/quickstart/index.md`:
- Line 33: In the kubectl output table on line 33 of the MariaDB quickstart
guide, the NAME column value is `10.5.23` but the VERSION column shows `11.8.5`.
Update the NAME column value from `10.5.23` to `11.8.5` to ensure consistency
between the NAME and VERSION columns, matching the pattern shown in the line
above where both values are identical.
---
Outside diff comments:
In `@docs/guides/mariadb/backup/stash/logical/standalone/index.md`:
- Around line 196-197: The task names in the kubectl output examples are
inconsistent with the updated spec.version. Throughout this documentation file,
replace all occurrences of the task name mariadb-backup-10.6.23 with
mariadb-backup-11.8.5 to match the spec.version that was updated to 11.8.5. This
includes all four locations mentioned: the task list output around lines
196-197, the BackupConfiguration verification output at line 310, the
BackupConfiguration paused state output at line 389, and the RestoreSession
task.name field at line 462.
In `@docs/guides/mariadb/concepts/mariadb-version/index.md`:
- Around line 44-92: The MariaDBVersion example has inconsistent version
references that should all align with 11.8.5. Update the spec.version field from
10.5.23 to 11.8.5 to match the metadata.name and spec.db.image version.
Additionally, update the spec.stash.addon.backupTask.name from
mariadb-backup-10.6.23 to mariadb-backup-11.8.5 and update the
spec.stash.addon.restoreTask.name from mariadb-restore-10.6.23 to
mariadb-restore-11.8.5 to ensure all version-specific task names are consistent
with the target MariaDB version.
In `@docs/guides/mariadb/configuration/using-config-file/index.md`:
- Around line 99-119: Update the MariaDB YAML manifest example to maintain
consistency with the actual manifest file and subsequent output examples. In the
YAML block defining the MariaDB resource, locate the spec.version field which
currently specifies "10.5.23" and change it to "11.8.5" to match both the
md-custom.yaml source manifest file and the output examples shown later in the
documentation.
In `@docs/guides/mariadb/initialization/git-sync.md`:
- Around line 83-95: The server version string in the MariaDB monitor welcome
output section displays a malformed mixed version identifier
"10.5.23-MariaDB-1:11.8.5+maria~ubu2004" that is inconsistent with the MariaDB
version "11.8.5" shown in both the kubectl output (line 83) and the spec
configuration (line 55). Update this version string in the MySQL welcome message
output to correctly show "11.8.5-MariaDB" as the primary version identifier to
maintain consistency across all version references in the documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 76a485a1-9aec-4430-a89b-c877d03f7157
📒 Files selected for processing (67)
docs/examples/mariadb/initialization/git-sync-public.yamldocs/examples/mariadb/restart/MariaDB.yamldocs/examples/mariadb/scaling/md-replication.yamldocs/examples/mariadb/volume-expansion/md-replication.yamldocs/guides/mariadb/autoscaler/compute/cluster/examples/sample-mariadb.yamldocs/guides/mariadb/autoscaler/compute/cluster/index.mddocs/guides/mariadb/autoscaler/storage/cluster/examples/sample-mariadb.yamldocs/guides/mariadb/autoscaler/storage/cluster/index.mddocs/guides/mariadb/backup/stash/auto-backup/examples/sample-mariadb-2.yamldocs/guides/mariadb/backup/stash/auto-backup/examples/sample-mariadb-3.yamldocs/guides/mariadb/backup/stash/auto-backup/examples/sample-mariadb.yamldocs/guides/mariadb/backup/stash/auto-backup/index.mddocs/guides/mariadb/backup/stash/customization/examples/sample-mariadb.yamldocs/guides/mariadb/backup/stash/logical/cluster/examples/sample-mariadb.yamldocs/guides/mariadb/backup/stash/logical/cluster/index.mddocs/guides/mariadb/backup/stash/logical/standalone/examples/sample-mariadb.yamldocs/guides/mariadb/backup/stash/logical/standalone/index.mddocs/guides/mariadb/clustering/galera-cluster/examples/demo-1.yamldocs/guides/mariadb/clustering/galera-cluster/index.mddocs/guides/mariadb/clustering/mariadb-replication/examples/demo-1.yamldocs/guides/mariadb/clustering/mariadb-replication/index.mddocs/guides/mariadb/concepts/appbinding/index.mddocs/guides/mariadb/concepts/mariadb-version/index.mddocs/guides/mariadb/concepts/mariadb/index.mddocs/guides/mariadb/configuration/using-config-file/examples/md-custom.yamldocs/guides/mariadb/configuration/using-config-file/index.mddocs/guides/mariadb/configuration/using-pod-template/examples/md-misc-config.yamldocs/guides/mariadb/configuration/using-pod-template/index.mddocs/guides/mariadb/custom-rbac/using-custom-rbac/examples/md-custom-db-2.yamldocs/guides/mariadb/custom-rbac/using-custom-rbac/examples/md-custom-db.yamldocs/guides/mariadb/custom-rbac/using-custom-rbac/index.mddocs/guides/mariadb/failover/guide.mddocs/guides/mariadb/initialization/git-sync.mddocs/guides/mariadb/initialization/using-script/example/demo-1.yamldocs/guides/mariadb/initialization/using-script/index.mddocs/guides/mariadb/monitoring/builtin-prometheus/examples/builtin-prom-md.yamldocs/guides/mariadb/monitoring/builtin-prometheus/index.mddocs/guides/mariadb/private-registry/quickstart/examples/demo.yamldocs/guides/mariadb/private-registry/quickstart/index.mddocs/guides/mariadb/quickstart/overview/examples/sample-mariadb-v1.yamldocs/guides/mariadb/quickstart/overview/index.mddocs/guides/mariadb/reconfigure-tls/cluster/examples/sample-mariadb.yamldocs/guides/mariadb/reconfigure-tls/cluster/index.mddocs/guides/mariadb/reconfigure/cluster/examples/sample-mariadb-config.yamldocs/guides/mariadb/reconfigure/cluster/index.mddocs/guides/mariadb/reconfigure/standalone/examples/sample-mariadb-config.yamldocs/guides/mariadb/reconfigure/standalone/index.mddocs/guides/mariadb/restart/restart.mddocs/guides/mariadb/rotate-auth/rotateauth.mddocs/guides/mariadb/scaling/horizontal-scaling/cluster/example/sample-mariadb.yamldocs/guides/mariadb/scaling/horizontal-scaling/cluster/index.mddocs/guides/mariadb/scaling/horizontal-scaling/maxscale.mddocs/guides/mariadb/scaling/vertical-scaling/cluster/example/sample-mariadb.yamldocs/guides/mariadb/scaling/vertical-scaling/cluster/index.mddocs/guides/mariadb/scaling/vertical-scaling/maxscale.mddocs/guides/mariadb/tls/configure/examples/tls-cluster.yamldocs/guides/mariadb/tls/configure/examples/tls-standalone.yamldocs/guides/mariadb/tls/configure/index.mddocs/guides/mariadb/update-version/cluster/examples/mdops-update.yamldocs/guides/mariadb/update-version/cluster/examples/sample-mariadb.yamldocs/guides/mariadb/update-version/cluster/index.mddocs/guides/mariadb/volume-expansion/maxscale.mddocs/guides/mariadb/volume-expansion/volume-expansion/example/sample-mariadb.yamldocs/guides/mariadb/volume-expansion/volume-expansion/index.mddocs/guides/mysql/autoscaler/compute/cluster/index.mddocs/guides/percona-xtradb/reconfigure/cluster/index.mddocs/guides/proxysql/backends/mariadb-galera/examples/mariadb-galera.yaml
Comment on lines
+230
to
+236
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:11.8.5+maria~focal started. | ||
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql' | ||
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:10.5.23+maria~focal started. | ||
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Initializing database files | ||
| ... | ||
| 2021-03-18 5:39:59 0 [Note] mysqld: ready for connections. | ||
| Version: '10.5.23-MariaDB-1:10.5.23+maria~focal' socket: '/run/mysqld/mysqld.sock' port: 3306 mariadb.org binary distribution | ||
| Version: '11.8.5-MariaDB-1:11.8.5+maria~focal' socket: '/run/mysqld/mysqld.sock' port: 3306 mariadb.org binary distribution |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Inconsistent version string in another-mariadb log output.
Line 232 shows an entrypoint message referencing MariaDB version 10.5.23, but the spec (line 200) and all other output lines in this block (230, 236) reference 11.8.5. This creates a confusing mixed-version log snippet.
Update line 232 to show version 11.8.5 consistently.
🔧 Proposed fix
2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:11.8.5+maria~focal started.
2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'
-2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:10.5.23+maria~focal started.
+2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:11.8.5+maria~focal started.
2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Initializing database files📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:11.8.5+maria~focal started. | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql' | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:10.5.23+maria~focal started. | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Initializing database files | |
| ... | |
| 2021-03-18 5:39:59 0 [Note] mysqld: ready for connections. | |
| Version: '10.5.23-MariaDB-1:10.5.23+maria~focal' socket: '/run/mysqld/mysqld.sock' port: 3306 mariadb.org binary distribution | |
| Version: '11.8.5-MariaDB-1:11.8.5+maria~focal' socket: '/run/mysqld/mysqld.sock' port: 3306 mariadb.org binary distribution | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:11.8.5+maria~focal started. | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql' | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:11.8.5+maria~focal started. | |
| 2021-03-18 05:39:50+00:00 [Note] [Entrypoint]: Initializing database files | |
| ... | |
| 2021-03-18 5:39:59 0 [Note] mysqld: ready for connections. | |
| Version: '11.8.5-MariaDB-1:11.8.5+maria~focal' socket: '/run/mysqld/mysqld.sock' port: 3306 mariadb.org binary distribution |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/guides/mariadb/custom-rbac/using-custom-rbac/index.md` around lines 230
- 236, The MariaDB log output contains an inconsistent version reference in the
entrypoint message. In the second entrypoint message line showing "Entrypoint
script for MySQL Server 1:10.5.23+maria~focal started", replace the version
string `10.5.23` with `11.8.5` to match the version specified in the spec and
shown in all other output lines (the final version string and the first
entrypoint message). This will ensure all version references in the log block
are consistent at version 11.8.5.
|
Visit the preview URL for this PR (updated for commit 02cbb7d): https://kubedb-v2-hugo--pr909-mariadb-version-aiy4mdgc.web.app (expires Wed, 01 Jul 2026 05:32:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
sheikh-arman
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
10.x/10.6.xreferences) across deployments, scaling, failover, TLS, backup/restore, initialization, and version upgrade content.