Conversation
Signed-off-by: Bonusree <bonusree@appscode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA new documentation guide is added at ChangesNew PostgreSQL Grafana Dashboard Guide
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit 5483597.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/guides/mssqlserver/backup/application-level/index.md`:
- Line 25: The KubeStash prerequisite link URL is missing a trailing slash that
is present in all other prerequisite links across the PR. In the line containing
the KubeStash setup link, add a trailing slash to the URL so it reads
https://kubestash.com/docs/latest/setup/ instead of
https://kubestash.com/docs/latest/setup to maintain consistent URL formatting
with the other seven changed files that use normalized paths with trailing
slashes.
In `@docs/guides/postgres/monitoring/grafana-dashboard.md`:
- Line 240: The guide incorrectly references the opnpulse/dashboards repository
for downloading PostgreSQL dashboards. Replace the repository link and
organization reference in the line that mentions downloading dashboard JSON
files from the incorrect location. Update the reference to point to the
appscode/grafana-dashboards repository on GitHub instead, maintaining the
postgres/ folder path reference while correcting both the organization name
(opnpulse to appscode) and the repository name (dashboards to
grafana-dashboards) in both the markdown link text and the URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a3ab2f49-8baa-4d6d-920b-4647945e6e19
📒 Files selected for processing (50)
docs/guides/cassandra/backup/kubestash/logical/index.mddocs/guides/cassandra/backup/kubestash/overview/index.mddocs/guides/druid/backup/application-level/index.mddocs/guides/druid/backup/auto-backup/index.mddocs/guides/druid/backup/cross-ns-dependencies/index.mddocs/guides/druid/backup/logical/index.mddocs/guides/druid/backup/overview/index.mddocs/guides/elasticsearch/backup/kubestash/auto-backup/index.mddocs/guides/elasticsearch/backup/kubestash/logical/index.mddocs/guides/elasticsearch/backup/kubestash/overview/index.mddocs/guides/mariadb/backup/kubestash/application-level/index.mddocs/guides/mariadb/backup/kubestash/auto-backup/index.mddocs/guides/mariadb/backup/kubestash/logical/index.mddocs/guides/mariadb/backup/kubestash/overview/index.mddocs/guides/mongodb/backup/kubestash/application-level/index.mddocs/guides/mongodb/backup/kubestash/auto-backup/index.mddocs/guides/mongodb/backup/kubestash/logical/replicaset/index.mddocs/guides/mongodb/backup/kubestash/logical/sharding/index.mddocs/guides/mongodb/backup/kubestash/logical/standalone/index.mddocs/guides/mongodb/backup/kubestash/overview/index.mddocs/guides/mongodb/schema-manager/deploy-mongodbdatabase/index.mddocs/guides/mongodb/schema-manager/initializing-with-script/index.mddocs/guides/mongodb/schema-manager/initializing-with-snapshot/index.mddocs/guides/mssqlserver/backup/application-level/index.mddocs/guides/mssqlserver/backup/auto-backup/index.mddocs/guides/mssqlserver/backup/logical/index.mddocs/guides/mssqlserver/backup/overview/index.mddocs/guides/mysql/backup/kubestash/application-level/index.mddocs/guides/mysql/backup/kubestash/auto-backup/index.mddocs/guides/mysql/backup/kubestash/logical/index.mddocs/guides/mysql/backup/kubestash/overview/index.mddocs/guides/postgres/backup/kubestash/application-level/index.mddocs/guides/postgres/backup/kubestash/auto-backup/index.mddocs/guides/postgres/backup/kubestash/logical/index.mddocs/guides/postgres/backup/kubestash/overview/index.mddocs/guides/postgres/monitoring/grafana-dashboard.mddocs/guides/qdrant/backup/logical/index.mddocs/guides/qdrant/backup/overview/index.mddocs/guides/qdrant/backup/volume-snapshot/index.mddocs/guides/redis/backup/kubestash/application-level/index.mddocs/guides/redis/backup/kubestash/auto-backup/index.mddocs/guides/redis/backup/kubestash/logical/index.mddocs/guides/redis/backup/kubestash/overview/index.mddocs/guides/singlestore/backup/kubestash/application-level/index.mddocs/guides/singlestore/backup/kubestash/auto-backup/index.mddocs/guides/singlestore/backup/kubestash/logical/index.mddocs/guides/singlestore/backup/kubestash/overview/index.mddocs/guides/zookeeper/backup/kubestash/auto-backup/index.mddocs/guides/zookeeper/backup/kubestash/logical/index.mddocs/guides/zookeeper/backup/kubestash/overview/index.md
| - At first, you need to have a Kubernetes cluster, and the `kubectl` command-line tool must be configured to communicate with your cluster. If you do not already have a cluster, you can create one by using `Minikube` or `Kind`. | ||
| - Install `KubeDB` in your cluster following the steps [here](/docs/setup/README.md). | ||
| - Install `KubeStash` in your cluster following the steps [here](https://kubestash.com/docs/latest/setup/install/kubestash). | ||
| - Install `KubeStash` in your cluster following the steps [here](https://kubestash.com/docs/latest/setup). |
There was a problem hiding this comment.
Inconsistent trailing slash breaks URL normalization pattern.
This file's URL lacks the trailing slash present in all other prerequisite links across the PR. All seven other changed files use https://kubestash.com/docs/latest/setup/ and https://kubedb.com/docs/latest/setup/ (with trailing slash), but this file uses https://kubestash.com/docs/latest/setup (without trailing slash).
This inconsistency may cause routing issues or 404 errors if the domain requires normalized path formatting.
🔧 Proposed fix
- Install `KubeStash` in your cluster following the steps [here](https://kubestash.com/docs/latest/setup).
+ Install `KubeStash` in your cluster following the steps [here](https://kubestash.com/docs/latest/setup/).🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 25-25: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/guides/mssqlserver/backup/application-level/index.md` at line 25, The
KubeStash prerequisite link URL is missing a trailing slash that is present in
all other prerequisite links across the PR. In the line containing the KubeStash
setup link, add a trailing slash to the URL so it reads
https://kubestash.com/docs/latest/setup/ instead of
https://kubestash.com/docs/latest/setup to maintain consistent URL formatting
with the other seven changed files that use normalized paths with trailing
slashes.
Signed-off-by: Bonusree <bonusree@appscode.com>
|
Visit the preview URL for this PR (updated for commit a44fe6c): https://kubedb-v2-hugo--pr890-grafana-0v1y8dcf.web.app (expires Thu, 25 Jun 2026 09:53:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Signed-off-by: Bonusree <bonusree@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit