fix(openant-cli): bound Python subprocess in Invoke with an automatic timeout#98
Open
gadievron wants to merge 1 commit into
Open
fix(openant-cli): bound Python subprocess in Invoke with an automatic timeout#98gadievron wants to merge 1 commit into
gadievron wants to merge 1 commit into
Conversation
… timeout Invoke built the Python subprocess with exec.Command (no context, no deadline), so a hung parser blocked the CLI forever on io.Copy/cmd.Wait. The only recovery was a user-delivered SIGINT, leaving headless callers (CI, scheduled scans, checkpoint.go quiet=true) with no recovery path. Switch the single subprocess-build site to exec.CommandContext driven by context.WithTimeout(defaultInvokeTimeout) — mirroring cmd/docker.go. The Invoke signature is unchanged, so all 10 callers are unaffected and the SIGINT fast-path is kept as a secondary mechanism. Killing the process is not sufficient on its own: a descendant can hold the stdout/stderr pipe write-ends open, leaving io.Copy blocked after the parent dies. cmd.WaitDelay force-closes the inherited FDs, and a watchdog goroutine closes the pipe read-ends on ctx.Done() so the in-flight reads return. defaultInvokeTimeout defaults to 30m and is a package var so tests can shrink it. New invoke_test.go::TestInvoke_HangingSubprocessIsBoundedByTimeout runs a fake parser that sleeps past the deadline and asserts Invoke returns within a bounded window (RED: blocked the full budget; GREEN: returns at the deadline). go test ./internal/python/ ok (21 passed); go vet + gofmt clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke built the Python subprocess with exec.Command (no context, no
deadline), so a hung parser blocked the CLI forever on io.Copy/cmd.Wait.
The only recovery was a user-delivered SIGINT, leaving headless callers
(CI, scheduled scans, checkpoint.go quiet=true) with no recovery path.
Switch the single subprocess-build site to exec.CommandContext driven by
context.WithTimeout(defaultInvokeTimeout) — mirroring cmd/docker.go. The
Invoke signature is unchanged, so all 10 callers are unaffected and the
SIGINT fast-path is kept as a secondary mechanism.
Killing the process is not sufficient on its own: a descendant can hold the
stdout/stderr pipe write-ends open, leaving io.Copy blocked after the parent
dies. cmd.WaitDelay force-closes the inherited FDs, and a watchdog goroutine
closes the pipe read-ends on ctx.Done() so the in-flight reads return.
defaultInvokeTimeout defaults to 30m and is a package var so tests can shrink
it. New invoke_test.go::TestInvoke_HangingSubprocessIsBoundedByTimeout runs a
fake parser that sleeps past the deadline and asserts Invoke returns within a
bounded window (RED: blocked the full budget; GREEN: returns at the deadline).
go test ./internal/python/ ok (21 passed); go vet + gofmt clean.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com