fix(context): anchor entry-point path exclusions on components, not substrings#94
Open
gadievron wants to merge 1 commit into
Open
Conversation
…ubstrings
detect_entry_points() skipped candidate files via `any(token in str(path))`
against the full absolute path at two sites (Python branch + JS/TS branch).
Short tokens ('test','tests','venv','dist','build') matched as substrings, so:
- real entry points whose name merely contains a token were skipped
(protest_api.py, latest/main.py, redistribute.js, buildings/);
- worse, a token in any ANCESTOR of repo_path (a CI checkout under
/build/ or /latest/) suppressed EVERY file -> detect_entry_points
returned '' -> downstream ApplicationType misclassification.
Fix: match on relative-path COMPONENTS via a shared _path_excluded() helper
(set-intersection on `relative_to(repo_path).parts`) plus anchored test-file
detection (test_*.py / *_test.py). Genuine node_modules/venv/dist/build dirs
and real test files stay excluded.
Tests: tests/test_application_context_entry_points_anchored.py (4 cases:
substring-FP python, parent-path-token, substring-FP js, genuine-exclusions
preserved). RED 4 failed -> GREEN 4 passed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detect_entry_points() skipped candidate files via
any(token in str(path))against the full absolute path at two sites (Python branch + JS/TS branch).
Short tokens ('test','tests','venv','dist','build') matched as substrings, so:
(protest_api.py, latest/main.py, redistribute.js, buildings/);
/build/ or /latest/) suppressed EVERY file -> detect_entry_points
returned '' -> downstream ApplicationType misclassification.
Fix: match on relative-path COMPONENTS via a shared path_excluded() helper
(set-intersection on
relative_to(repo_path).parts) plus anchored test-filedetection (test*.py / *_test.py). Genuine node_modules/venv/dist/build dirs
and real test files stay excluded.
Tests: tests/test_application_context_entry_points_anchored.py (4 cases:
substring-FP python, parent-path-token, substring-FP js, genuine-exclusions
preserved). RED 4 failed -> GREEN 4 passed.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com