fix(parsers/go): give CodeQL DB-create the same timeout budget as analyze#89
Open
gadievron wants to merge 1 commit into
Open
fix(parsers/go): give CodeQL DB-create the same timeout budget as analyze#89gadievron wants to merge 1 commit into
gadievron wants to merge 1 commit into
Conversation
…lyze go/test_pipeline.py ran `codeql database create` with timeout=600s and `codeql database analyze` with timeout=1800s. DB creation compiles the source -- the slower stage for compiled languages -- so the slower stage had the smaller budget and times out first. On a create timeout run_codeql_analysis records the codeql stage success=False and returns; run_full_pipeline prints "continuing with reachable units only" and proceeds, and apply_codeql_filter (test_pipeline.py:1009, success-gated) is skipped -- so the written dataset is reachable-only with CodeQL findings dropped. The run does report success=False / exit 1 (all_success ANDs the failed stage, :1040-1045, :1199), so an exit-code CI gate still catches it; the harm is the silently-degraded artifact for any consumer that reads the results rather than the exit code. Extract both stage timeouts to named module constants and set the create budget equal to analyze (1800s), so the create stage is no longer shortchanged. Scope: the c/php/js/ruby test_pipeline.py orchestrators carry the same inverted timeouts and are separate units -- not widened here. Tests: tests/test_go_test_pipeline_codeql_timeout.py -- two checks that read the source rather than importing the module (which does module-level sys.path manipulation and shares its name with sibling parser test_pipeline.py): the create timeout >= analyze timeout, and that both call sites pass the named constants (not inline literals, which could silently drift the budget back). RED -> GREEN; full suite 178 passed, 63 skipped, 0 failed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go/test_pipeline.py ran
codeql database createwith timeout=600s andcodeql database analyzewithtimeout=1800s. DB creation compiles the source -- the slower stage for compiled languages -- so the slower
stage had the smaller budget and times out first. On a create timeout run_codeql_analysis records the codeql
stage success=False and returns; run_full_pipeline prints "continuing with reachable units only" and proceeds,
and apply_codeql_filter (test_pipeline.py:1009, success-gated) is skipped -- so the written dataset is
reachable-only with CodeQL findings dropped. The run does report success=False / exit 1 (all_success ANDs the
failed stage, :1040-1045, :1199), so an exit-code CI gate still catches it; the harm is the silently-degraded
artifact for any consumer that reads the results rather than the exit code.
Extract both stage timeouts to named module constants and set the create budget equal to analyze (1800s), so
the create stage is no longer shortchanged.
Scope: the c/php/js/ruby test_pipeline.py orchestrators carry the same inverted timeouts and are separate
units -- not widened here.
Tests: tests/test_go_test_pipeline_codeql_timeout.py -- two checks that read the source rather than importing
the module (which does module-level sys.path manipulation and shares its name with sibling parser
test_pipeline.py): the create timeout >= analyze timeout, and that both call sites pass the named constants
(not inline literals, which could silently drift the budget back). RED -> GREEN; full suite 178 passed,
63 skipped, 0 failed.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com