fix(cli/runtime): key dependency-staleness on corePath, not only the pyproject hash#104
Open
gadievron wants to merge 1 commit into
Open
Conversation
…pyproject hash The managed Python venv is a single global path (~/.openant/venv) shared by every worktree. The staleness check (depsStalenessAt) keyed only on pyproject.toml content, so two worktrees with identical pyproject.toml were considered "up to date" even though the venv's editable install (`pip install -e <corePath>`) pointed at whichever worktree installed last -- a binary built in worktree B would silently import worktree A's Python source. Introduce depsHash(corePath) = sha256(corePath + "\0" + pyproject.toml contents) and use it for both the install baseline stamp and the staleness comparison. A change of corePath (switching worktrees) now reads as stale and triggers a reinstall that re-points the editable install at the active source. (hashFile remains a tested file-hash utility, no longer on the staleness path.) Tests: internal/python/runtime_corepath_test.go (two worktrees with byte-identical pyproject but different corePath -> the second is detected as stale; same corePath -> not stale). RED 1 failed -> GREEN; go test ./internal/python/ ok (existing staleness + hashFile tests unaffected); gofmt + vet clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The managed Python venv is a single global path (~/.openant/venv) shared by every worktree. The
staleness check (depsStalenessAt) keyed only on pyproject.toml content, so two worktrees with
identical pyproject.toml were considered "up to date" even though the venv's editable install
(
pip install -e <corePath>) pointed at whichever worktree installed last -- a binary built inworktree B would silently import worktree A's Python source.
Introduce depsHash(corePath) = sha256(corePath + "\0" + pyproject.toml contents) and use it for both
the install baseline stamp and the staleness comparison. A change of corePath (switching worktrees)
now reads as stale and triggers a reinstall that re-points the editable install at the active source.
(hashFile remains a tested file-hash utility, no longer on the staleness path.)
Tests: internal/python/runtime_corepath_test.go (two worktrees with byte-identical pyproject but
different corePath -> the second is detected as stale; same corePath -> not stale). RED 1 failed ->
GREEN; go test ./internal/python/ ok (existing staleness + hashFile tests unaffected); gofmt + vet clean.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com