fix(progress): floor ETA remaining at 0 so retry double-counts don't show negative time#102
Open
gadievron wants to merge 1 commit into
Open
fix(progress): floor ETA remaining at 0 so retry double-counts don't show negative time#102gadievron wants to merge 1 commit into
gadievron wants to merge 1 commit into
Conversation
…show negative time ProgressReporter.report() does an unconditional `self.completed += 1`, so a retried unit re-reports and `completed` can exceed `total`. _estimate_remaining then computed `remaining_units = self.total - self.completed` < 0, rendering the ETA as a negative duration (e.g. "ETA ~-30s"). Floor it at max(0, ...). Tests: tests/test_progress_eta_no_underflow.py (2 cases). RED 1 failed -> GREEN 2 passed; full suite 178 passed / 63 skipped (py3.11). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProgressReporter.report() does an unconditional
self.completed += 1, so a retried unitre-reports and
completedcan exceedtotal. _estimate_remaining then computedremaining_units = self.total - self.completed< 0, rendering the ETA as a negativeduration (e.g. "ETA ~-30s"). Floor it at max(0, ...).
Tests: tests/test_progress_eta_no_underflow.py (2 cases). RED 1 failed -> GREEN 2 passed;
full suite 178 passed / 63 skipped (py3.11).
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com