Skip to content

change(web): add tokenized prediction intermediate type for whitespace correction support 🚂 🔪#15907

Draft
jahorton wants to merge 3 commits into
change/web/multi-token-suggestion-similarityfrom
change/web/multi-token-prediction-intermediates
Draft

change(web): add tokenized prediction intermediate type for whitespace correction support 🚂 🔪#15907
jahorton wants to merge 3 commits into
change/web/multi-token-suggestion-similarityfrom
change/web/multi-token-prediction-intermediates

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

@jahorton jahorton commented May 4, 2026

Converts early uses of CompositedPredictionData to TokenizedPredictionData to facilitate important token-based aspects of whitespace correction support, such as case-handling.

🚧
TODO: also contains changes to prediction-parameters that ease handling of various predictive behaviors. Those should be hoisted to earlier PRs and/or spun off into a parent PR.
🚧

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot Bot commented May 4, 2026

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot Bot changed the title change(web): rework prediction intermediate type for whitespace correction support change(web): rework prediction intermediate type for whitespace correction support 🚂 May 4, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S28 milestone May 4, 2026
@jahorton jahorton force-pushed the change/web/multi-token-prediction-intermediates branch from e8f3cad to 1a3e571 Compare May 6, 2026 20:17
@jahorton jahorton changed the base branch from feat/web/multi-token-predict-core to change/web/rework-traversalless-prediction May 6, 2026 20:17
@jahorton jahorton force-pushed the change/web/multi-token-prediction-intermediates branch from 1a3e571 to b243fc8 Compare May 6, 2026 20:19
@jahorton jahorton force-pushed the change/web/rework-traversalless-prediction branch from f8a1e49 to daea6e5 Compare May 7, 2026 18:22
@jahorton jahorton force-pushed the change/web/multi-token-prediction-intermediates branch from eb8c98b to 96b044a Compare May 7, 2026 18:45
@keyman-server keyman-server modified the milestones: A19S28, A19S29 May 11, 2026
@jahorton jahorton force-pushed the change/web/multi-token-prediction-intermediates branch from 5150f26 to e622a4b Compare May 12, 2026 17:09
@jahorton jahorton changed the base branch from change/web/rework-traversalless-prediction to fix/web/create-default-keep May 12, 2026 18:28
@jahorton jahorton force-pushed the change/web/multi-token-prediction-intermediates branch from e622a4b to d79d54a Compare May 12, 2026 19:43
@jahorton jahorton changed the base branch from fix/web/create-default-keep to change/web/multi-token-suggestion-similarity May 12, 2026 19:43
@jahorton jahorton changed the title change(web): rework prediction intermediate type for whitespace correction support 🚂 change(web): add tokenized prediction intermediate type for whitespace correction support May 12, 2026
@keymanapp-test-bot keymanapp-test-bot Bot changed the title change(web): add tokenized prediction intermediate type for whitespace correction support change(web): add tokenized prediction intermediate type for whitespace correction support 🚂 May 12, 2026
@github-actions github-actions Bot added the change Minor change in functionality, but not new label May 13, 2026
@keyman-server keyman-server modified the milestones: A19S29, A19S30 May 23, 2026
@jahorton jahorton force-pushed the change/web/multi-token-suggestion-similarity branch from 61fc801 to 96339dc Compare May 28, 2026 21:43
jahorton added 3 commits May 29, 2026 16:38
…e correction support

Converts early uses of CompositedPredictionData to TokenizedPredictionData to facilitate important token-based aspects of whitespace correction support, such as case-handling.

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the change/web/multi-token-prediction-intermediates branch from b763609 to 71a9162 Compare May 29, 2026 21:40
@keymanapp-test-bot keymanapp-test-bot Bot changed the title change(web): add tokenized prediction intermediate type for whitespace correction support 🚂 change(web): add tokenized prediction intermediate type for whitespace correction support 🚂 🔪 May 29, 2026
tokens.push({
correction: entry,
casingRoot: orderedTokens ? orderedTokens[i].exampleInput : entry.sample.insert,
autoSelectable: correctionValidForAutoSelect(entry.sample.insert)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, along with the changes to the PredictionParameters interface, should probably be migrated earlier as well - likely to the implementation of buildCorrectionSequence in #16028 (or earlier, if it can be moved earlier to prevent reworking things like #15851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants