fix: Use same sort keys for listings of trees on HardwareDetails page.#1908
Merged
gustavobtflores merged 1 commit intoMay 18, 2026
Merged
Conversation
There were instances of sorting the lists of trees in the hardware page using a different set of keys (due to mistake on the performance improvements of kernelci#1832). This case might have not triggered, because the sorting provided by the first 2 keys tree_name/branch, might suffice for basically most of the comparisons. * All of them are now using the keys (in order of importance): 1. tree_name 2. branch, 3. git_repository_url 4. git_commit_hash Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
alanpeixinho
force-pushed
the
fix/treesort-hardware-details
branch
from
0080ffc to
d7c069b
Compare
gustavobtflores
added
Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were instances of sorting the lists of trees in the hardware
page using a different set of keys (due to mistake on the performance
improvements of #1832).
This case might have not triggered, because the sorting provided by
the first 2 keys tree_name/branch, might suffice for basically most of
the comparisons.
All of them are now using the keys (in order of importance):
Closes Wrong sorting of trees on hardware details. #1907