library: refine interactive cover hotspots, info card, and assorted library UI#153
Conversation
…ibrary UI Calibrate InteractiveCover panorama hotspot geometry via coordinate remap with per-hotspot overrides, make the LibraryInfoCard glass blur constant so it shows immediately on reveal, and bundle the remaining library UI refinements. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
@claude, review this PR. |
|
Claude finished @MaryWylde's task in 4m 49s —— View job PR Review: library-refinements
OverviewSolid PR overall — the coordinate remap system is well-designed, the blur fix is correct, and several UX gaps (visitor search, "Create library" gating, share button layout) are cleanly addressed. A few things need attention before merge. InteractiveCover — hotspot coordinate remap
The geometry is sound. The One geometry concern — // coverHotspots.ts:172
{ hit: { left: 34.7824, top: 0 } },The wide geometry has The
The LibraryInfoCard — glass blur fix
Correct fix. Moving - backdrop-filter: blur(0);
- -webkit-backdrop-filter: blur(0);
+ backdrop-filter: blur(8px);
+ -webkit-backdrop-filter: blur(8px);
transition:
background 0.45s ease,
- backdrop-filter 0.45s ease,
- -webkit-backdrop-filter 0.45s ease;
border-color 0.45s ease;The Placeholder data will reach production
All five hotspot entries use: const lorem = 'Lorem ipsum dolor sit amet…'
libraryName: 'John's Library',
about: lorem,
bookCount: 123,These are live data that will render in the
|
| Approve with fixes | Placeholder hotspot data and the library-test.png naming need resolution before this lands in production. |
| Minor | house-2 top: 0 override, gendered pronoun in visitor toolbar, redundant .min(1) in tag schema. |
| Pre-existing | RatingBox "rated this book" copy applies to all object types — worth fixing alongside this polish pass. |
….png Give the ultra-wide cover art a descriptive name matching library.png and library-wide.png, replacing the placeholder library-test.png and updating its references in the cover layout, styles, and hotspot geometry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The recipient (read-only) view renders no action buttons, so the full header padding left the bare title floating; drop the vertical padding to 5px there. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Calibrate InteractiveCover panorama hotspot geometry via coordinate remap with per-hotspot overrides, make the LibraryInfoCard glass blur constant so it shows immediately on reveal, and bundle the remaining library UI refinements.