Skip to content
This repository was archived by the owner on Feb 8, 2025. It is now read-only.

migrate to rand 0.9.0#12

Closed
coszio wants to merge 1 commit into
jonhoo:mainfrom
coszio:migrate-to-rand-0.9.0
Closed

migrate to rand 0.9.0#12
coszio wants to merge 1 commit into
jonhoo:mainfrom
coszio:migrate-to-rand-0.9.0

Conversation

@coszio

@coszio coszio commented Jan 28, 2025

Copy link
Copy Markdown

This migrates the usage of rand to what it expects in the new version, so that it implements the right traits that have been changed. Here is the migration guide.

Before this, it was not possible to use this crate alongside a newer rand version. After this, this crate will probably not be backward compatible with earlier rand versions

This migrates the usage of `rand` to what it expects in the new version.
Before this, it was not possible to use this crate alongside a newer
rand version. After this, this crate will probably not be backward
compatible with earlier rand versions
@rkuris

rkuris commented Jan 30, 2025

Copy link
Copy Markdown

+1 please merge this so we can use the latest rand

@tisonkun

tisonkun commented Feb 3, 2025

Copy link
Copy Markdown

cc @jonhoo

@rkuris

rkuris commented Feb 4, 2025

Copy link
Copy Markdown

+1 please merge this so we can use the latest rand

No longer needed, migrated to rand_distr

@tisonkun

tisonkun commented Feb 4, 2025

Copy link
Copy Markdown

@rkuris Interesting. Could you share the PR for migration? I may follow your solution :P

@rkuris

rkuris commented Feb 4, 2025 via email

Copy link
Copy Markdown

@tisonkun

tisonkun commented Feb 4, 2025

Copy link
Copy Markdown

Thanks. I tried it at foyer-rs/foyer#854.

@jonhoo

jonhoo commented Feb 8, 2025

Copy link
Copy Markdown
Owner

Sorry for the delay! Now that there is Zipf support directly in rand_distr (as of rust-random/rand#1136), that's probably the one to use! I had generally hoped that rand would move away from "all the distributions in one crate", but given that they're moving the other direction, I think it probably doesn't make sense to maintain this separately any more, so I'll go ahead and deprecate it. Especially since it seems rand uses effectively the same method.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants