Skip to content

TextOnly Filter#49

Merged
jaytaylor merged 1 commit into
jaytaylor:masterfrom
copoer:master
Nov 5, 2021
Merged

TextOnly Filter#49
jaytaylor merged 1 commit into
jaytaylor:masterfrom
copoer:master

Conversation

@copoer

@copoer copoer commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

For those who do not want any text formatting except new lines

@trypsynth

Copy link
Copy Markdown

@jaytaylor, it looks like this would close #52. Is there a reason it hasn't been merged yet?

@iredmail

iredmail commented Nov 1, 2021

Copy link
Copy Markdown

I need this feature too, hopefully this could be merged. :)

btw, is it better to rename JustText to TextOnly or NoExtraFormatting?

@Kleissner

Copy link
Copy Markdown

TextOnly definitely makes more sense.

@copoer copoer changed the title JustText TextOnly Nov 1, 2021
@jaytaylor

Copy link
Copy Markdown
Owner

@copoer Happy to work together to get this merged! Are you able to (pretty please) squash it into a single commit?

@iredmail

iredmail commented Nov 2, 2021

Copy link
Copy Markdown

Are you able to (pretty please) squash it into a single commit?

GitHub offers a button to squash the commands and merge, that means you can do it directly by one click. :)

@jaytaylor

Copy link
Copy Markdown
Owner

This is true, but would this lead to a commit history polluted with WIP? OP - please clean up and squash the commits so we can merge this baby

@iredmail

iredmail commented Nov 3, 2021

Copy link
Copy Markdown

This is true, but would this lead to a commit history polluted with WIP?

No. Only one commit after merged. :)

@iredmail

iredmail commented Nov 3, 2021

Copy link
Copy Markdown

By the way, could you tag a new version after merged this PR?
It would be great to use Go module too, see #42

@copoer

copoer commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

Sorry about the weird git history. I had to mess with it a bit to squash it 😅

@copoer copoer changed the title TextOnly TextOnly Filter Nov 3, 2021
@jaytaylor

Copy link
Copy Markdown
Owner

Beautiful! Thank you @copoer !!!!!

@jaytaylor jaytaylor merged commit bc68cce into jaytaylor:master Nov 5, 2021
@jaytaylor

Copy link
Copy Markdown
Owner

By the way, could you tag a new version after merged this PR? It would be great to use Go module too, see #42

@iredmail I'm on it, haven't created tags for my go libraries before but let's give it a shot. I will follow up in #42.

@Millak Millak mentioned this pull request Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants