Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Update git-control-view.coffee#247

Open
jayspirits wants to merge 1 commit into
jacogr:masterfrom
jayspirits:master
Open

Update git-control-view.coffee#247
jayspirits wants to merge 1 commit into
jacogr:masterfrom
jayspirits:master

Conversation

@jayspirits

@jayspirits jayspirits commented Oct 13, 2017

Copy link
Copy Markdown

This is a fix from split of undefined issue.
Used 'repo.workingDirectory' from gitRepository object instead of 'path' for setWorkspaceTitle. 'path' is no longer available in the object.

Used repo.workingDirectory from gitRepository object for setWorkspaceTitle. 'path' is no longer available in the object.
@ttristan

Copy link
Copy Markdown

thanks @jayspirits
for those who don't know how to fix until the new version is released:
move to C:\Users\[username]\.atom\packages\git-control\lib\git-control-view.coffee and change line 76 to:
@setWorkspaceTitle(git.getRepository().repo.workingDirectory.split('/').reverse()[1])

@areichman

Copy link
Copy Markdown

@TS-DE Making that change to line 76 allowed me to load the package, but attempting to select a repo using the "Project" button returns the same error noted in #248.

@Generic42

Copy link
Copy Markdown

I'm running into the same issues, I made the change that @TS-DE suggested, which resolve the first error. However now when trying to switch projects I get the error as detailed in #248

@Generic42

Copy link
Copy Markdown

I made the additional change referenced here #245 (comment)

Now I can switch projects properly.

@gforge

gforge commented Nov 23, 2017

Copy link
Copy Markdown

I think you also need to add the workinDirectory in project-dialog.coffe line 46 due to the same issue. I also suspect that line 33 is also affected.

@Dharshan2004

Copy link
Copy Markdown

Thanks it works

@kaizvn

kaizvn commented Feb 11, 2019

Copy link
Copy Markdown

please merge this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants