Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
ion-routerAPI docs listion-navas one of the navigation outlets thation-routercoordinates. That's inaccurate.ion-navmanages its own imperative navigation stack and isn't URL-coordinated, which its own docs already state ("pushing others won't affect overall routers").With this change, the outlet list on the
ion-routerpage names onlyion-tabsandion-router-outlet. Applied to the<head>meta description and both overview sentences.The same wording exists in the v8 and v7 snapshots since the inaccuracy predates all three, so I corrected
versioned_docs/version-v8/api/router.mdandversioned_docs/version-v7/api/router.mdto match.Also documented migration path for those using
ion-navas a router outlet.