docs(datetime): update method links for confirmation buttons section#4584
Open
thetaPC wants to merge 1 commit into
Open
docs(datetime): update method links for confirmation buttons section#4584thetaPC wants to merge 1 commit into
thetaPC wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
The "Showing Confirmation Buttons" section of the
ion-datetimedocs links to theconfirmandcancelmethods using(#confirm)and(#cancel). The generated method anchors now carry amethod-prefix ({#method-confirm},{#method-cancel}), so these links no longer resolve and don't scroll to the Methods section.What is the new behavior?
The links point to the correct anchors,
(#method-confirm)and(#method-cancel), so they once again jump to the corresponding entries in the Methods section.Does this introduce a breaking change?
Other information
No other method links were found broken.