Skip to content

feat(cred-req/endpoints): add support for requesting credentials by endpoints#65

Open
Dominik Kadera (dominikkadera) wants to merge 3 commits into
mainfrom
dka/credentials-for-endpoints
Open

feat(cred-req/endpoints): add support for requesting credentials by endpoints#65
Dominik Kadera (dominikkadera) wants to merge 3 commits into
mainfrom
dka/credentials-for-endpoints

Conversation

@dominikkadera

Copy link
Copy Markdown
Member

I'm adding possibility to start sending appEndpoints as input to the Credential Requests when creating them "by targets", similarly as we do it with Modules already. Thanks to this, the Scope Inference is done by Make, and caller doesn't need to bother -- simplifies life for the Agents.

@dominikkadera Dominik Kadera (dominikkadera) marked this pull request as ready for review July 2, 2026 14:07
@dominikkadera Dominik Kadera (dominikkadera) requested a review from a team as a code owner July 2, 2026 14:07
Copilot AI review requested due to automatic review settings July 2, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Credential Requests “create action” flow to support specifying credential targets via appEndpoints (in addition to appModules), enabling Make-side scope inference and simplifying credential request creation for callers/agents.

Changes:

  • Updated CredentialSelection to allow specifying appEndpoints alongside (or instead of) appModules.
  • Extended tool definitions for credential-requests_create to accept appEndpoints in the credential selection schema.
  • Added unit + integration coverage for creating credential actions using appEndpoints.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/credential-requests.spec.ts Adds a unit test verifying createAction sends appEndpoints in the request body.
test/credential-requests.integration.test.ts Adds an integration test creating (and deleting) an action using appEndpoints.
src/endpoints/credential-requests.ts Updates public SDK types to allow credential selection by endpoint names.
src/endpoints/credential-requests.tools.ts Extends tool input schema/types to include appEndpoints for create action requests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/endpoints/credential-requests.ts Outdated
Comment thread src/endpoints/credential-requests.tools.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants