feat(cred-req/endpoints): add support for requesting credentials by endpoints#65
Open
Dominik Kadera (dominikkadera) wants to merge 3 commits into
Open
feat(cred-req/endpoints): add support for requesting credentials by endpoints#65Dominik Kadera (dominikkadera) wants to merge 3 commits into
Dominik Kadera (dominikkadera) wants to merge 3 commits into
Conversation
Copilot started reviewing on behalf of
Dominik Kadera (dominikkadera)
July 2, 2026 14:07
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Credential Requests “create action” flow to support specifying credential targets via appEndpoints (in addition to appModules), enabling Make-side scope inference and simplifying credential request creation for callers/agents.
Changes:
- Updated
CredentialSelectionto allow specifyingappEndpointsalongside (or instead of)appModules. - Extended tool definitions for
credential-requests_createto acceptappEndpointsin the credential selection schema. - Added unit + integration coverage for creating credential actions using
appEndpoints.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/credential-requests.spec.ts | Adds a unit test verifying createAction sends appEndpoints in the request body. |
| test/credential-requests.integration.test.ts | Adds an integration test creating (and deleting) an action using appEndpoints. |
| src/endpoints/credential-requests.ts | Updates public SDK types to allow credential selection by endpoint names. |
| src/endpoints/credential-requests.tools.ts | Extends tool input schema/types to include appEndpoints for create action requests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot started reviewing on behalf of
Dominik Kadera (dominikkadera)
July 2, 2026 15:07
View session
Andrii Chumak (andriichumak)
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding possibility to start sending
appEndpointsas input to the Credential Requests when creating them "by targets", similarly as we do it with Modules already. Thanks to this, the Scope Inference is done by Make, and caller doesn't need to bother -- simplifies life for the Agents.