Feature/missing hana tests#3886
Merged
Merged
Conversation
thoniTUB
reviewed
May 6, 2026
Collaborator
thoniTUB
left a comment
thoniTUB
left a comment
There was a problem hiding this comment.
Hier werden viele Tests gelöscht, ist das korrekt?
# Conflicts: # backend/src/test/resources/tests/aggregator/COUNT_QUARTERS_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/COUNT_QUARTERS_AGGREGATOR/content.csv # backend/src/test/resources/tests/aggregator/DURATION_SUM_AGGREGATOR/DURATION_SUM.test.json # backend/src/test/resources/tests/aggregator/DURATION_SUM_DISTINCT_AGGREGATOR/DURATION_SUM.test.json # backend/src/test/resources/tests/aggregator/EVENT_DATE_AGGREGATOR/EVENT_DATE_AGGREGATOR_NO_RESTRICTION.test.json # backend/src/test/resources/tests/aggregator/EVENT_DATE_AGGREGATOR/EVENT_DATE_AGGREGATOR_RESTRICTION.test.json # backend/src/test/resources/tests/aggregator/EXISTS_AGGREGATOR/NUMBER.test.json # backend/src/test/resources/tests/aggregator/EXISTS_AGGREGATOR_OR/NUMBER.test.json # backend/src/test/resources/tests/aggregator/FIRST_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/FLAGS_AGGREGATOR/FLAGS_AGGREGATOR.test.json # backend/src/test/resources/tests/aggregator/LAST_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/DISTINCT/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/DISTINCT_MULTI/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/FIRST/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/MAPPED/FIRST_MULTI/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/QUARTER_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/RANDOM_AGGREGATOR/SIMPLE_VIRTUAL_CONCEPT_Query.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/DISTINCT/MAPPED.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/DISTINCT/SIMPLE.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/DISTINCT_MULTI/MAPPED.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/FIRST/MAPPED.test.json # backend/src/test/resources/tests/aggregator/SUBSTRING/FIRST/SIMPLE.test.json
awildturtok
force-pushed
the
feature/missing-hana-tests
branch
from
98afbcc to
59832b1
Compare
Closed
thoniTUB
approved these changes
May 20, 2026
Collaborator
thoniTUB
left a comment
thoniTUB
left a comment
There was a problem hiding this comment.
habe nur kleinigkeiten angemerkt :)
| Selects preprocessingSelects = Selects.builder() | ||
| .ids(tableContext.getIds()) | ||
| .validityDate(tableContext.getValidityDate()) | ||
| .validityDate(Optional.of(tableContext.getValidityDate())) |
Collaborator
There was a problem hiding this comment.
Wird das Optional-packing weiter unten sinnvoll? Optionals sollte man eher bei Rückgabewerten nutzen nicht als member oder Argument
awildturtok
commented
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.