Fix zeros_like/ones_like/empty_like for scalar and array_like inputs#505
Open
cycsmail wants to merge 1 commit into
Open
Fix zeros_like/ones_like/empty_like for scalar and array_like inputs#505cycsmail wants to merge 1 commit into
cycsmail wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
*_likehelpers assumeother_aryis aGPUArrayand read.allocator/.flagsoff it, so passing a scalar or other array_like blows up. This mirrors numpy by running non-GPUArrayinputs throughnp.asarrayand falling back to the defaultdrv.mem_allocallocator; theGPUArraypath is unchanged.Added a small test for scalar /
np.float32inputs alongside the existing*_likechecks.Heads up: I don't have a CUDA box here, so I only exercised the
_array_like_helperlogic locally and couldn't run the GPU suite. Worth confirming on your GitLab CI.Fixes #389.