[codex] Remove obsolete Expo demo dependency#767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expodev dependency and the stale Expo/Jest/demo-only package metadata.maininto Expo mode.Why
Dependabot alert #1 flags
expo < 48.0.0viaGHSA-wr5g-q49g-548w/CVE-2023-28131. The root Expo demo was stale and is not part of the published package (filesonly publishesdist), so removing that demo path fixes the alert without migrating the legacy library to a newer Expo runtime.Validation
npm install --legacy-peer-deps --ignore-scripts --package-lock=falsenpm run typechecknpm run buildnpm ls expo --allreturns emptygit diff --checkNote: the legacy dependency tree still reports unrelated audit findings during install; this PR is scoped to the open Expo Dependabot alert.