feat: add Brandt Smart Control authentication#2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrandtAuthStrategyimplementing Brandt's two-layer auth: log in to the Smart Control middleware (smartcontrol-app.com, a cookie-session Rails API), fetch a JWT using the resulting session cookie, then log in to the Overkiz cloud withjwt=<JWT>only.aiohttp.ClientSessioncookie jar, so the JWT GET is authenticated purely by the session cookie set on login.BRANDT_MIDDLEWARE_API/BRANDT_PARTNERconstants andBrandtBadCredentialsError/BrandtServiceErrorexceptions, following the Cozytouch/Nexity precedent.Server.BRANDTto the new strategy in the auth factory (it previously fell through to the genericSessionLoginStrategyand silently failed).Test Plan
pytest tests/test_auth.py— newTestBrandtAuthStrategy(success flow, bad credentials, missing JWT) + factory routing test, all passing