Skip to content

add PR fork workable#13438

Merged
sayakpaul merged 7 commits intomainfrom
fix-review
Apr 16, 2026
Merged

add PR fork workable#13438
sayakpaul merged 7 commits intomainfrom
fix-review

Conversation

@paulinebm
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot added CI size/M PR with diff < 200 LOC labels Apr 9, 2026
Comment thread .github/workflows/claude_review.yml Outdated
@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 9, 2026
Comment thread .github/workflows/claude_review.yml Outdated
@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 9, 2026
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. LMK if they are clear.

Comment thread .github/workflows/claude_review.yml Outdated
Comment thread .github/workflows/claude_review.yml
Comment on lines +129 to +130
"Bash(git commit*)",
"Bash(git push*)",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be able to commit specific rules to the rule file, actually:

1. NEVER modify, create, or delete files — unless the human comment contains verbatim:
               COMMIT THIS (uppercase). If committing, only touch src/diffusers/ and .ai/.

How do we tackle that with this denial?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with keeping the claude CI read-only for now so we can get this PR merged quickly and get it into action:)

we can figure out how to allow it commit in safe way in a follow-up PR? @sayakpaul

Copy link
Copy Markdown
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this @paulinebm!
i left one comment

Comment thread .github/workflows/claude_review.yml Outdated
Comment on lines +129 to +130
"Bash(git commit*)",
"Bash(git push*)",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with keeping the claude CI read-only for now so we can get this PR merged quickly and get it into action:)

we can figure out how to allow it commit in safe way in a follow-up PR? @sayakpaul

@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 16, 2026
Co-authored-by: YiYi Xu <yixu310@gmail.com>
@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 16, 2026
@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 16, 2026
Co-authored-by: Pauline Bailly-Masson <155966238+paulinebm@users.noreply.github.com>
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@github-actions github-actions bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 16, 2026
@sayakpaul sayakpaul merged commit e0c1ec4 into main Apr 16, 2026
14 of 15 checks passed
@sayakpaul sayakpaul deleted the fix-review branch April 16, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size/M PR with diff < 200 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants