fix(render): seek single-composition (-c) renders at the requested fps#1714
Open
func25 wants to merge 1 commit into
Open
fix(render): seek single-composition (-c) renders at the requested fps#1714func25 wants to merge 1 commit into
func25 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
render -c <scene> -f 60outputs a 60fps file whose motion only advances at 30fps (every other frame is a duplicate). The same scene in the full reel is fine. Verified it is not dedup and not VFR.Why
A single
<template>composition rendered with-cmounts under a synthetic wrapper root that has no timeline of its own; only the inner composition registers inwindow.__timelines. So:canonicalFps(30), not the export fps.How
window.__hfCanonicalFps) before page scripts so the runtime seeks on the export grid. Honors--fps.Test plan
How was this tested?