Skip to content

FE-862: Add icons to @hashintel/ds-components and export HelpTooltip and TextMark#8865

Merged
CiaranMn merged 1 commit into
mainfrom
cm/add-icons-to-ds-components
Jun 12, 2026
Merged

FE-862: Add icons to @hashintel/ds-components and export HelpTooltip and TextMark#8865
CiaranMn merged 1 commit into
mainfrom
cm/add-icons-to-ds-components

Conversation

@CiaranMn

Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

I need additional icons and to make use of HelpTooltip and TextMark in a tool I'm importing into HASH.

This PR adds those.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@CiaranMn CiaranMn requested review from alex-e-leon and Copilot June 12, 2026 15:21
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jun 12, 2026 3:21pm
hashdotdesign-tokens Ready Ready Preview, Comment Jun 12, 2026 3:21pm
petrinaut Ready Ready Preview, Comment Jun 12, 2026 3:21pm

@cursor

cursor Bot commented Jun 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Additive patch: new icon assets/map entries and two new public exports; no behavior changes to existing components.

Overview
Extends @hashintel/ds-components so consumers can use seven new Icon names and two components that were already in the package but not on the public entrypoint.

Icons: New SVG assets and IconMap keys — arrowTrendDown, arrowTrendUp, fileLines, grid, print, puzzlePiece, and truck — so IconName / iconNames include them. A patch changeset records the release.

Public API: main.ts now re-exports HelpTooltip and TextMark (no implementation changes in this diff).

Reviewed by Cursor Bugbot for commit 56440a3. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @hashintel/ds-components public surface to support additional UI usage in HASH by adding several new icon assets and exporting two existing components (HelpTooltip and TextMark) from the package entrypoint.

Changes:

  • Export HelpTooltip and TextMark from libs/@hashintel/ds-components/src/main.ts.
  • Add several new regular icon SVGs and register them in IconMap so they’re available via <Icon name="…" />.
  • Add a changeset for publishing @hashintel/ds-components.

Reviewed changes

Copilot reviewed 3 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/@hashintel/ds-components/src/main.ts Exposes HelpTooltip and TextMark from the package entrypoint.
libs/@hashintel/ds-components/src/components/Icon/icon.tsx Imports and registers new icon SVGs in IconMap.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/arrow-trend-up.svg Adds new icon asset.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/arrow-trend-down.svg Adds new icon asset.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/file-lines.svg Adds new icon asset.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/grid-2.svg Adds new icon asset.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/print.svg Adds new icon asset.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/puzzle-piece.svg Adds new icon asset.
libs/@hashintel/ds-components/src/components/Icon/svgs/regular/truck.svg Adds new icon asset.
.changeset/heavy-months-post.md Records a patch release note for @hashintel/ds-components.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .changeset/heavy-months-post.md
@alex-e-leon

Copy link
Copy Markdown
Contributor

Lgtm

@CiaranMn CiaranMn changed the title FE-862: Add icons to @hsahintel/ds-components and export HelpTooltip and TextMark FE-862: Add icons to @hashintel/ds-components and export HelpTooltip and TextMark Jun 12, 2026
@CiaranMn CiaranMn enabled auto-merge June 12, 2026 16:55
@CiaranMn CiaranMn added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 8494d8a Jun 12, 2026
53 checks passed
@CiaranMn CiaranMn deleted the cm/add-icons-to-ds-components branch June 12, 2026 17:13
@hash-worker hash-worker Bot mentioned this pull request Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

3 participants