FE-472: fix type header appearance#8861
Conversation
PR SummaryMedium Risk Overview Slide stack changes hide the top context bar action menu in slides, fix breadcrumb hrefs for link vs entity types, nudge bar spacing so breadcrumbs sit below the back/forward/close controls, and drop an extra Panda CSS is wired into hash-frontend: new Reviewed by Cursor Bugbot for commit ea16fbb. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
CiaranMn
left a comment
There was a problem hiding this comment.
Definitely an improvement! One comment on the diff and a couple of styling things that we'd ideally fix while touching this:
- Title text can be cut off (due to line height probably and no overflow?) – see the 'g' below
- Needs some margin with the description
- For non link types where the plural title spans multiple rows, 'plural' looks a bit close to the actual plural title... maybe we should just use the layout for link types (above) always, i.e. just stack 'plural' and the plural title vertically rather than putting on the same horizontal row
Sure thing, I'll fix these up. How is is that the base line-height is so bad : ( |
|
Can we make sure the vertical ellipsis icon/breadcrumbs always sit on the same row as the close button when the latter is present? I thought we'd fixed this prior. |
fb32019 to
865af0d
Compare
865af0d to
dc14b82
Compare
|
@CiaranMn I've fixed up the other issues you mentioned - let me know if there's anything else. Also left a few comments where I made some choices with non-local impacts. LMK your thoughts on those before I apply them. |
CiaranMn
left a comment
There was a problem hiding this comment.
One outstanding issue, which is that the context menu can overlap the back/forward/close bar. I mentioned before that we could potentially just hide the context menu dots when in a slide. Otherwise its right offset will need to vary based upon which additional buttons are visible (back, forward, close)
059ecc5 to
0345dc2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0345dc2. Configure here.
0345dc2 to
23397e7
Compare
Ok fixed in the last commit. |

🌟 What is the purpose of this PR?
Fixes issues with layout in entity-header and introduces panda-css to hash-frontend so that ds-components can be loaded in. A couple of notes:
I also have no idea why the mui-button drops its padding when under stress.FixedPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: