Skip to content

FE-751: Style username in signup-registration messaging#8857

Merged
alex-e-leon merged 1 commit into
mainfrom
FE-751-fix-signup-username-messaging
Jun 12, 2026
Merged

FE-751: Style username in signup-registration messaging#8857
alex-e-leon merged 1 commit into
mainfrom
FE-751-fix-signup-username-messaging

Conversation

@alex-e-leon

@alex-e-leon alex-e-leon commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Adds a small amount of styling to help improve the comprehension of the messaging on the user signup page by making it clear that @pizza is a username.

Although personally, I still find that the copy reads uncomfortably and I think updating the copy would be a better fix. Here's a couple alternatives I cobbled together that I think could work better:

  • Before someone else grabs @pizza (if we want to run with a subtle pizza joke)
  • To get a short handle like @pizza (neutral, but clear)
  • Be @you, not @you2087 (if we want something with a bit more urgency/marketing copy - may need to reserve those usernames though)

@vilkinsons let me know if you prefer any of them and I'll switch them over - otherwise I'll just keep the original messaging.

Finally - the new styles:
Screenshot 2026-06-11 at 15 37 42

(And old for reference):
Screenshot 2026-06-11 at 15 33 37

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@alex-e-leon alex-e-leon requested a review from CiaranMn June 11, 2026 13:34
@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jun 11, 2026 1:45pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Jun 11, 2026 1:45pm
petrinaut Skipped Skipped Jun 11, 2026 1:45pm

@cursor

cursor Bot commented Jun 11, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy-only presentation change on the signup marketing panel; no auth, API, or data logic touched.

Overview
On the signup page sidebar (SignupRegistrationRightInfo), the “Reserve your username” line now renders @pizza inside a <code> element instead of plain text, and the description field type is widened to React.ReactNode so that markup is allowed.

Description Typography gains nested code styles (monospace font, slightly smaller type, lighter blue text, subtle light background, rounded padding) so the example reads clearly as a username/handle.

Reviewed by Cursor Bugbot for commit ed41831. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels Jun 11, 2026
@alex-e-leon alex-e-leon force-pushed the FE-751-fix-signup-username-messaging branch from 593b285 to ed41831 Compare June 11, 2026 13:37
@vercel vercel Bot temporarily deployed to Preview – petrinaut June 11, 2026 13:37 Inactive

@TimDiekmann TimDiekmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with you that the copy could be better. But this already is an improvement -> ✅

@vilkinsons

Copy link
Copy Markdown
Member

"Before someone else grabs pizza" reads best burial bleeds over 2 lines therefore is undesirable?

@alex-e-leon

Copy link
Copy Markdown
Contributor Author

@vilkinsons it only breaks on 2 lines between 1100px > 900px screen sizes (ie tablets). On my laptop its all one line:

Screenshot 2026-06-11 at 16 18 43

And here's the tablet version - it looks fine IMO.
Screenshot 2026-06-11 at 16 21 18

@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 12, 2026
@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit f5cd3ed Jun 12, 2026
47 checks passed
@alex-e-leon alex-e-leon deleted the FE-751-fix-signup-username-messaging branch June 12, 2026 09:49
@alex-e-leon

Copy link
Copy Markdown
Contributor Author

@vilkinsons - I've merged without the copy change, but put up a new PR with just the copy change here and tagged you in it: #8862

Just hit approve or close the PR depending on which outcome you prefer : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

4 participants