FE-751: Style username in signup-registration messaging#8857
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
PR SummaryLow Risk Overview Description Typography gains nested Reviewed by Cursor Bugbot for commit ed41831. Bugbot is set up for automated code reviews on this repo. Configure here. |
593b285 to
ed41831
Compare
TimDiekmann
left a comment
There was a problem hiding this comment.
Agreed with you that the copy could be better. But this already is an improvement -> ✅
|
"Before someone else grabs pizza" reads best burial bleeds over 2 lines therefore is undesirable? |
|
@vilkinsons it only breaks on 2 lines between 1100px > 900px screen sizes (ie tablets). On my laptop its all one line:
|
|
@vilkinsons - I've merged without the copy change, but put up a new PR with just the copy change here and tagged you in it: #8862 Just hit approve or close the PR depending on which outcome you prefer : ) |


🌟 What is the purpose of this PR?
Adds a small amount of styling to help improve the comprehension of the messaging on the user signup page by making it clear that @pizza is a username.
Although personally, I still find that the copy reads uncomfortably and I think updating the copy would be a better fix. Here's a couple alternatives I cobbled together that I think could work better:
@vilkinsons let me know if you prefer any of them and I'll switch them over - otherwise I'll just keep the original messaging.
Finally - the new styles:

(And old for reference):

Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: