Conversation
- Pull lib-jsonnet PR adopted-ember-addons#257 (adds packageManager='pnpm' support to util.workflowJavascriptPackage). - Rewrite .github.jsonnet to use packageManager='pnpm', node:24 image, isPublicFork=true, and a test job that runs lint:hbs/lint:js/build. - Regenerate workflows; publish targets GitHub Packages only (no more npm.gynzy.net references). - Remove legacy ci/npm.sh and ci/publish.sh (superseded by helpers). Depends on lib-jsonnet#257; follow-up will repin to prod once it merges.
- package.json: add packageManager=pnpm@10.33.4, publishConfig pointing at npm.pkg.github.com, engines.node>=24, bump version 4.0.13 -> 4.1.0. - .npmrc: scope @gynzy to npm.pkg.github.com. - .nvmrc: pin Node 24. - .husky/pre-commit: replace yarn lint with direct pnpm lint:hbs/lint:js (the umbrella lint script still calls yarn internally; left untouched per migration scope). - Replace yarn.lock with pnpm-lock.yaml.
- package.json: lint script now uses pnpm instead of yarn. - .husky/pre-commit: call pnpm run lint (umbrella) instead of the individual sub-scripts. - .github.jsonnet/workflows: testJob now runs pnpm run lint instead of lint:hbs/lint:js separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
@gynzy/ember-sortableto pnpm 10, Node 24, and GitHub Packages publishing on top ofutil.workflowJavascriptPackage()from lib-jsonnet.Migration scope
10.33.4(replaces yarn).24(replaces14.* || >= 16).https://npm.pkg.github.com). Nonpm.gynzy.net/setGynzyNpmTokenleft in generated YAML.pull-upstream-and-rebuild.sh.Dependency
gynzy/lib-jsonnet#257(addspackageManager='pnpm'toworkflowJavascriptPackage). Once Created importable modern test helpers adopted-ember-addons/ember-sortable#257 merges to prod, follow up withsh .github/jsonnet/pull-upstream-and-rebuild.sh(noPR_NUMBER) to repin to prod.Discovery / decisions
PUBLIC->isPublicFork=true.main.4.0.13->4.1.0(minor +1, patch reset).scripts.testnot defined; onlytest:emberandtest:allexist (run Ember tests viaember test/ember try:each). Existing CI did not run tests either, so the new test job runs the same checks current CI would:lint:hbs,lint:js,build. The Ember test commands were left out of CI to match the existing behaviour and avoid expanding migration scope.ember build(invoked viapnpm run build).pnpm run lint:hbsandpnpm run lint:jsare invoked directly in the test job because the umbrellalintscript inpackage.jsonstill callsyarninternally. Per migration scope,scriptswere not modified; only.husky/pre-commitwas updated fromyarn lintto directpnpm run lint:hbs/pnpm run lint:jsso local pre-commit keeps working under pnpm.testJob.publish-prodtriggers on push tomainonly. Helper preserves that.Removed legacy
ci/npm.sh,ci/publish.sh(handwritten yarn/npm.gynzy.net publish helpers) -- superseded by helper-generated jobs.Preserved non-helper pipelines
None; the repo had no side-pipelines.
Verification
Locally, on a clean
pnpm install:pnpm run lint:hbspasses.pnpm run lint:jspasses.pnpm run buildsucceeds (only a benign "Ember CLI v4.12.3 not tested against Node v24" warning).node:24,pnpm, and nonpm.gynzy.net/setGynzyNpmTokenstrings.Open Questions
ember test/ember try:eachare not exercised in CI today and remain out of CI here. If we want the addon test suite to gate PRs, that's a follow-up (it would also need a browser environment, which is out of scope for this migration).