forked from Colisweb/JRubyConcurrentConstantMemoryExcel
-
Notifications
You must be signed in to change notification settings - Fork 0
Modernize #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Modernize #1
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
11f8d07
Modernize
guizmaii c804a0e
Modernize
guizmaii 19ff578
Modernize
guizmaii d4b6acb
Apply suggestion from @Copilot
guizmaii 2640a5f
Modernize
guizmaii 3684e63
Merge remote-tracking branch 'origin/update_0' into update_0
guizmaii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name-template: '$RESOLVED_VERSION' | ||
| tag-template: '$RESOLVED_VERSION' | ||
|
|
||
| version-resolver: | ||
| major: | ||
| labels: | ||
| - 'major' | ||
| minor: | ||
| labels: | ||
| - 'minor' | ||
| patch: | ||
| labels: | ||
| - 'patch' | ||
| default: minor | ||
|
|
||
| categories: | ||
| - title: 'Features' | ||
| label: 'enhancement' | ||
| - title: 'Bug Fixes' | ||
| label: 'bug' | ||
|
|
||
| exclude-labels: | ||
| - 'skip' | ||
|
|
||
| autolabeler: | ||
| - label: 'bug' | ||
| title: | ||
| - '/.*\[fix\].*/' | ||
| - label: 'patch' | ||
| title: | ||
| - '/.*\[fix\].*/' | ||
| - label: 'enhancement' | ||
| title: | ||
| - '/.*\[feat\].*/' | ||
| - label: 'minor' | ||
| title: | ||
| - '/.*\[feat\].*/' | ||
| - label: 'skip' | ||
| title: | ||
| - '/.*\[skip\].*/' | ||
| - label: 'major' | ||
| title: | ||
| - '/.*\[breaking\].*/' | ||
|
|
||
| replacers: | ||
| - search: '/\[feat\]/g' | ||
| replace: '' | ||
| - search: '/\[fix\]/g' | ||
| replace: '' | ||
| - search: '/\[skip\]/g' | ||
| replace: '' | ||
| - search: '/\[breaking\]/g' | ||
| replace: '' | ||
|
|
||
| template: | | ||
| # What's Changed | ||
|
|
||
| $CHANGES | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [master, main] | ||
| pull_request: | ||
| branches: [master, main] | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| java: [ '17', '21', '25' ] | ||
| steps: | ||
| - run: env | ||
| shell: bash | ||
| - uses: actions/checkout@v6 | ||
| - uses: sbt/setup-sbt@v1 | ||
| - uses: coursier/cache-action@v8 | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: temurin | ||
| java-version: ${{ matrix.java }} | ||
| check-latest: true | ||
| - name: tests | ||
| run: | | ||
| sbt clean test | ||
|
|
||
| formatting: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: env | ||
| shell: bash | ||
| - uses: actions/checkout@v6 | ||
| - uses: sbt/setup-sbt@v1 | ||
| - uses: coursier/cache-action@v8 | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 | ||
| check-latest: true | ||
| - name: Formatting | ||
| run: | | ||
| sbt scalafmtSbtCheck scalafmtCheck test:scalafmtCheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Release Drafter | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| update_release_draft: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| # write permission is required to create a github release | ||
| contents: write | ||
| # write permission is required for autolabeler | ||
| # otherwise, read permission is required at least | ||
| pull-requests: write | ||
| steps: | ||
| - uses: release-drafter/release-drafter@v7.1.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Release | ||
|
|
||
| on: | ||
| push: | ||
| branches: [master, main] | ||
| release: | ||
| types: [ published ] | ||
|
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: env | ||
| shell: bash | ||
| - uses: actions/checkout@v6 | ||
| - uses: sbt/setup-sbt@v1 | ||
| - uses: coursier/cache-action@v8 | ||
| - uses: olafurpg/setup-gpg@v3 | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 | ||
| check-latest: true | ||
| - run: sbt ci-release | ||
| env: | ||
| PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} | ||
| PGP_SECRET: ${{ secrets.PGP_SECRET }} | ||
| SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
| SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Scala Steward | ||
|
|
||
| # This workflow will launch everyday at 00:00 | ||
| on: | ||
| schedule: | ||
| - cron: '0 0 * * *' | ||
| workflow_dispatch: {} | ||
|
|
||
| jobs: | ||
| scala-steward: | ||
| timeout-minutes: 45 | ||
| runs-on: ubuntu-latest | ||
| name: Scala Steward | ||
| steps: | ||
| - uses: sbt/setup-sbt@v1 | ||
| - name: Scala Steward | ||
| uses: scala-steward-org/scala-steward-action@v2.86.0 | ||
| with: | ||
| github-repository: ${{ github.repository }} | ||
| github-token: ${{ secrets.SCALA_STEWARD }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # This is a comment | ||
| -Dfile.encoding=UTF8 | ||
| -Xms128M | ||
| -Xmx4G | ||
| -Xss16M | ||
| -XX:+UseG1GC | ||
| --add-opens=java.base/java.util=ALL-UNNAMED | ||
| --add-opens=java.base/java.lang=ALL-UNNAMED | ||
| --add-exports=java.base/sun.nio.ch=ALL-UNNAMED | ||
| --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED | ||
| --enable-native-access=ALL-UNNAMED # Removes some warnings when starting sbt on JDK25+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| rules = [ | ||
| DisableSyntax | ||
| // ExplicitResultTypes // Waiting for: https://github.com/scalacenter/scalafix/issues/1583 | ||
| LeakingImplicitClassVal | ||
| NoAutoTupling | ||
| NoValInForComprehension | ||
| OrganizeImports | ||
| RemoveUnused | ||
| RedundantSyntax | ||
| ] | ||
|
|
||
| DisableSyntax.regex = [] | ||
| DisableSyntax.noReturns = true | ||
| DisableSyntax.noXml = true | ||
| DisableSyntax.noFinalize = true | ||
|
|
||
| // Preset rules compatible with Intellij IDEA | ||
| // See: https://scalacenter.github.io/scalafix/docs/rules/OrganizeImports.html#intellij_2020_3 | ||
| OrganizeImports { | ||
| preset = INTELLIJ_2020_3 | ||
| targetDialect = Scala3 | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,31 @@ | ||
| style = defaultWithAlign | ||
| maxColumn = 120 | ||
| version = "3.10.7" | ||
| runner.dialect = scala3 # https://scalameta.org/scalafmt/docs/configuration.html#scala-3 | ||
|
guizmaii marked this conversation as resolved.
|
||
| runner.dialectOverride.allowSignificantIndentation = false # See https://x.com/ghostdogpr/status/1706589471469425074 | ||
| maxColumn = 140 | ||
| align.preset = most | ||
| continuationIndent.defnSite = 2 | ||
| assumeStandardLibraryStripMargin = true | ||
| docstrings.style = Asterisk | ||
| lineEndings = preserve | ||
| includeCurlyBraceInSelectChains = true | ||
| danglingParentheses.preset = true | ||
| optIn.annotationNewlines = true | ||
| newlines.alwaysBeforeMultilineDef = false | ||
| newlines.implicitParamListModifierPrefer = before | ||
| trailingCommas = keep | ||
| docstrings.wrap = no | ||
|
|
||
| rewrite.rules = [RedundantBraces, SortModifiers] | ||
|
|
||
| rewrite.sortModifiers.order = [ | ||
| "implicit", "override", "private", "protected", "final", "sealed", "abstract", "lazy" | ||
| ] | ||
| rewrite.redundantBraces.generalExpressions = false | ||
| rewrite.redundantBraces.stringInterpolation = true | ||
| rewriteTokens = { | ||
| "⇒": "=>" | ||
| "→": "->" | ||
| "←": "<-" | ||
| } | ||
|
|
||
| project.excludePaths = [] | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scalafix is configured with
targetDialect = Scala3, which can rewrite imports/syntax to Scala 3 forms even though the build uses Scala 2.13. This is likely to introduce non-compiling rewrites; aligntargetDialectwith the actual Scala version (or migrate to Scala 3).