Align types for new cricket scorecard and header#15841
Open
Jakeii wants to merge 3 commits into
Open
Conversation
Jakeii
added
the
maintenance
Jakeii
added
run_chromatic
github-actions
Bot
removed
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
There are slightly different types used by these 2 components, I've combined them into the start of a new module, following what was done for the new football component types.
I haven't added any parsing, just types for now.
Why?
Attempted to use both of these components together and realised they were slightly different!