fix(security): 2 improvements across 2 files#15830
Open
tomaioo wants to merge 2 commits intoguardian:mainfrom
Open
fix(security): 2 improvements across 2 files#15830tomaioo wants to merge 2 commits intoguardian:mainfrom
tomaioo wants to merge 2 commits intoguardian:mainfrom
Conversation
- Security: Tabnabbing vulnerability in external links - Security: Tabnabbing vulnerability in external links Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Tabnabbing vulnerability in external links - Security: Tabnabbing vulnerability in external links Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:ab-testing/frontend/src/lib/components/OphanLink.svelte:L10The OphanLink.svelte and GrafanaLink.svelte components use target="_blank" without rel="noopener noreferrer", which allows the opened page to access window.opener and potentially redirect the original page. This is a known security issue called tabnabbing.
Solution
Add rel="noopener noreferrer" to the anchor tag:
Changes
ab-testing/frontend/src/lib/components/OphanLink.svelte(modified)ab-testing/frontend/src/lib/components/GrafanaLink.svelte(modified)