PR_4

.github/workflows/ci.yml

@@ -127,7 +127,7 @@ jobs:
           fi
 
       - name: Run tests (--all)
-        run: xvfb-run -a uv run ./scripts/runtest.py --all
+        run: xvfb-run -a uv run ./scripts/runtest.py --suite all
 
   update:
     if: github.event_name == 'push' && github.ref == 'refs/heads/main' && !contains(github.event.head_commit.message, '[skip ci]')
@@ -236,7 +236,7 @@ jobs:
           fi
 
       - name: Run tests and update README (--update)
-        run: xvfb-run -a uv run ./scripts/runtest.py --update
+        run: xvfb-run -a uv run ./scripts/runtest.py --suite all --update
 
       - name: Commit and push updated README
         run: |

.gitignore

@@ -17,3 +17,5 @@ PeterSQL.png
 
 # Unready build scripts
 scripts/build/nix/
+assets/
+screenshot/

ENGINES.md

@@ -7,6 +7,7 @@ This project stores SQL autocomplete vocabulary in normalized engine specificati
 The specification model uses a **base + delta** strategy:
 
 - `common.functions` and `common.keywords` contain the shared baseline for that engine.
+- Added support for stored functions in MySQL and MariaDB contexts, including deterministic flag handling.
 - `versions.<major>.functions_remove` and `versions.<major>.keywords_remove` remove entries that are not valid for an older major version.
 
 We intentionally keep newer capabilities in `common` and apply only removals for older majors.
@@ -19,3 +20,33 @@ At runtime, vocabulary resolution uses:
 2. otherwise, the highest configured major version `<=` the server major.
 
 Example: if PostgreSQL server major is `19` and the highest configured major is `18`, version `18` is used.
+
+## Inter-Engine API Differences and Feature Parity
+
+The engine layer exposes a common base API (`SQLTable`, `SQLColumn`, `SQLIndex`, `SQLForeignKey`, `SQLRecord`, `SQLView`, `SQLTrigger`, `SQLCheck`, `SQLFunction`, `SQLProcedure`, `SQLDatabase`). Engines implement this API with the following known variations:
+
+### SQLite
+
+- File-based storage: `SQLiteDatabase.create()`, `alter()`, and `drop()` raise `NotImplementedError` because database lifecycle is managed at the filesystem level, not via SQL DDL.
+- Most mature engine path with complete CRUD for tables, columns, indexes, foreign keys, records, views, and triggers.
+- Check constraints are **partial**: read/create/delete are implemented; update depends on a recreate strategy.
+- Functions and procedures are **not applicable** (N/A).
+
+### MySQL / MariaDB
+
+- Strong parity for tables, columns, indexes, foreign keys, records, views, triggers, and functions.
+- Check constraints and procedures are **partial**: engine objects exist (`MySQLCheck`, `MySQLProcedure`, `MariaDBCheck`, `MariaDBProcedure`), but cross-version validation is ongoing.
+- Database create/drop lifecycle methods exist at the engine level, but context/UI wiring remains read/list-oriented.
+
+### PostgreSQL
+
+- Core CRUD available for tables, columns, indexes, foreign keys, records, views, and triggers.
+- Functions and procedures are **partial**: `PostgreSQLFunction` and `PostgreSQLProcedure` are implemented but still under broader validation.
+- Check constraints are **partial**: `PostgreSQLCheck` and `get_checks()` exist; cross-version validation ongoing.
+- Database create/drop lifecycle methods exist at the engine level, but context/UI wiring remains read/list-oriented.
+- Schema and sequence objects have basic visibility but no CRUD layer yet.
+
+### Shared Base Contracts
+
+- `SQLColumn` and `SQLIndex` are enforced as abstract base classes (`abc.ABC`) with `@abstractmethod` decorators on public methods (`add`, `drop`, `rename`, `modify`, `create`, `raw_create`). Missing implementations are caught at class definition time.
+- Equality comparisons (`__eq__`) on `SQLDatabase` and `SQLForeignKey` use identity-based field matching rather than inverted logic.

PROJECT_STATUS.md

@@ -1,6 +1,6 @@
 # PeterSQL — Project Status
 
-> **Last Updated:** 2026-04-27
+> **Last Updated:** 2026-06-05
 > **Status Rule:** newly implemented features are tracked as **PARTIAL** until validated across supported versions.
 > **Definition of DONE:** engine methods implemented, integration tests pass on target versions, UI workflow exists (if user-facing), no known regressions, documentation updated.
 
@@ -127,8 +127,8 @@
   - **Next:** cross-version validation matrix.
 
 - [x] **Connection reliability updates** (PARTIAL)
-  - **Scope:** persistent connection statistics, empty DB password support, TLS auto-retry (MySQL/MariaDB).
-  - **Files:** `structures/connection.py`, `windows/dialogs/connections/`
+  - **Scope:** persistent connection statistics, empty DB password support, TLS auto-retry (MySQL/MariaDB), keyring-backed password storage.
+  - **Files:** `structures/connection.py`, `windows/dialogs/connections/`, `structures/secrets.py`
   - **Next:** SSH testcontainers integration validation (currently skipped) + long-run behavioral validation.
 
 - [x] **SQL dump/backup object-driven flow** (PARTIAL)
@@ -172,15 +172,18 @@
 
 ## 5. Progress Snapshot
 
-- **P0 implemented (partial):** 5/5
-- **P1 gaps closed:** 2/3
+- **P0 implemented (partial):** 5/5 — all resolved
+- **P1 gaps closed:** 3/3 — all resolved
+- **P2 technical audit items:** 2/2 — resolved (PostgreSQL import/type hints, ABC enforcement)
 - **P2 UI tasks complete:** 4/8
 - **P3 advanced tasks complete:** 0/6
 
 ---
 
 ## 6. Recently Added
 
+- Connection passwords are now stored in the system keyring (`keyring`), removing plaintext passwords from `connections.yml`.
+- Audit fixes completed: PostgreSQL alter diff handling, equality comparisons, SQLite column/drop/modify signatures, SQLite database lifecycle errors, SQLite record exception safety, VERSION sync, PostgreSQL import/type hints, and ABC enforcement for `SQLColumn`/`SQLIndex`.
 - SQL autocomplete extended to INSERT / UPDATE / DELETE and string literals; parser improved with JSON and multi-table coverage.
 - Table execution flow updated in the records UI.
 - `row_format` and `convert_data` options added to the MySQL/MariaDB table editor.