fix(next-ui): don't render disabled pagination items as links#2643
Merged
Conversation
Disabled PaginationItems were still given a `component`/`href`, turning them into anchors. Crawlers follow those links to an unbounded number of list pages, needlessly building up the static page cache. Only pass `component`/`href` when the item is enabled; disabled items fall back to a plain button, so bots no longer have a link to crawl. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 04ba9be The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled PaginationItems were still given a
component/href, turning them into anchors. Crawlers follow those links to an unbounded number of list pages, needlessly building up the static page cache.Only pass
component/hrefwhen the item is enabled; disabled items fall back to a plain button, so bots no longer have a link to crawl.