chore(alerting): Gate alertingQueryAndExpressionsStepMode FT on Grafana version#2758
Closed
konstantinmv wants to merge 4 commits into
Closed
chore(alerting): Gate alertingQueryAndExpressionsStepMode FT on Grafana version#2758konstantinmv wants to merge 4 commits into
konstantinmv wants to merge 4 commits into
Conversation
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🧑💻 In development
in Grafana Catalog Team
…remove-step-mode-ft
github-project-automation
Bot
moved this from 🧑💻 In development
to 🔬 In review
in Grafana Catalog Team
Collaborator
|
Slightly alternative / more comprehensive fix #2762 |
Author
Yes, that's much better, thank you for taking the time to open it! I spent some time yesterday looking into the nighlty failure but couldn't figure it out that quick, thanks again for this. |
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update
AlertRuleEditPage.isAdvancedModeSupported()to account for the removal of the alertingQueryAndExpressionsStepMode feature toggle in Grafana 13.2.0.Why
In Grafana 13.2.0 the toggle was removed and the advanced query/expression mode switch became always available (GA).
##How
Advanced mode is now considered supported when either:
Follow-up to grafana/grafana#125086.