Skip to content

Remove Exclamation Marks#118

Open
gowerc wants to merge 2 commits into
masterfrom
112-no-explanation-marks
Open

Remove Exclamation Marks#118
gowerc wants to merge 2 commits into
masterfrom
112-no-explanation-marks

Conversation

@gowerc

@gowerc gowerc commented Jul 26, 2024

Copy link
Copy Markdown
Owner

Closes #112

@github-actions

github-actions Bot commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  --------------------------
R/ascii_tables.R          105       8  92.38%   10, 148, 158, 163-166, 211
R/cast_variables.R         49       0  100.00%
R/diffdf.R                209      18  91.39%   373-390, 417
R/generate_keyname.R       10       1  90.00%   16
R/identify.R              152       8  94.74%   283-290
R/is_different.R           52       0  100.00%
R/issuerows.R              40       0  100.00%
R/issues.R                 17       1  94.12%   51
R/misc_functions.R         34       2  94.12%   9, 13
R/print.R                  20       0  100.00%
TOTAL                     688      38  94.48%

Results for commit: 219939a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   13 suites   6s ⏱️
 52 tests  51 ✅ 1 💤 0 ❌
578 runs  571 ✅ 7 💤 0 ❌

Results for commit 219939a.

♻️ This comment has been updated with latest results.

@kieranjmartin kieranjmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the exclamation marks from the news.md is very funny, but probably unintentional?

I would recommend saving this for 2.0. I suspect some of the printed behaviour may be encoded, so I would probably do this in a more breaking release.

@gowerc gowerc added the Blocked label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lets rid of double exclamation marks

2 participants