chore: sync skills with Discovery API#775
Conversation
🦋 Changeset detectedLatest commit: 45462fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated synchronization of the project's skill definitions with the latest Google Discovery API specifications. The changes primarily involve updating documentation and command metadata to ensure the CLI accurately reflects current API capabilities and usage patterns. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request synchronizes the CLI skill documentation with the latest Google Discovery API specifications. Key updates include adding the findGroupChats method to Google Chat, expanding the approvals resource and adding generateCseToken in Google Drive, and refining subscription and push notification documentation for Google Events and Gmail. Additionally, the documentation for the Google Sheets append skill was clarified regarding the --range parameter. I have no feedback to provide as there were no review comments to assess.
85b5f64 to
961c5b7
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request synchronizes the generated skills documentation with the latest Google Discovery API specifications. Key updates include adding the findGroupChats method to the Chat skill, expanding the Drive skill with comprehensive approval management methods and a CSE token generation method, and enhancing documentation for Gmail push notifications and Event subscriptions. I have no feedback to provide as there were no review comments to assess.
f2e6906 to
c6c2b89
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for several Google Workspace skills, including Chat, Drive, Events, Gmail, and Sheets, to synchronize them with the latest Google Discovery API specifications. Key additions include the findGroupChats method for Chat, a comprehensive set of approval-related methods and generateCseToken for Drive, and enhanced descriptions with documentation links for Events and Gmail subscriptions and watches. I have no feedback to provide.
c6c2b89 to
98b7bf9
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request syncs the generated skills documentation for the Google Workspace CLI with the latest Discovery API specifications. Key updates include the addition of the findGroupChats method in Chat, a comprehensive set of approval-related methods and CSE token generation in Drive, and clarified documentation for Events subscriptions, Gmail push notifications, and Sheets append operations. I have no feedback to provide as there were no review comments to assess.
6befffb to
2958745
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for several Google Workspace skills (Chat, Drive, Events, Gmail, and Sheets) to align with the latest Google Discovery API specifications. Key changes include adding new methods for Chat group chats and Drive approvals, as well as refining descriptions and adding documentation links for existing methods. I have no feedback to provide.
2958745 to
1d4d4cf
Compare
|
/gemini review |
7b18085 to
dd3a683
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request synchronizes the generated skills documentation with the latest Google Discovery API specifications. Key updates include adding the findGroupChats method to Google Chat, expanding the approvals and files (CSE token) methods in Google Drive, and providing more detailed descriptions for subscriptions in Google Events and push notifications in Gmail. Additionally, the documentation for the Google Sheets append skill was clarified regarding the --range flag. I have no feedback to provide.
dd3a683 to
03d0535
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for various Google Workspace skills (Chat, Classroom, Drive, Events, Gmail, and Sheets) to align with the latest Google Discovery API specifications. Key changes include adding new methods like findGroupChats in Chat and several approval-related methods in Drive, as well as refining descriptions and error handling details across other services. I have no feedback to provide.
03d0535 to
89beda0
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request synchronizes the generated skills documentation for the Google Workspace CLI with the latest Google Discovery API specifications. Key updates include the addition of the findGroupChats method in Chat, expanded approval and CSE token methods in Drive, and refined documentation for Classroom, Events, Gmail, and Sheets. I have no feedback to provide.
1488c4f to
027b75b
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request synchronizes the generated skills documentation with the latest Google Discovery API specifications. Key updates include the addition of the findGroupChats method in Chat, expanded approval and CSE token methods in Drive, and detailed subscription handling for Chat events. Documentation for Classroom, Gmail, and Sheets-append was also refined for clarity and accuracy. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request synchronizes the Google Workspace CLI skills with the latest Google Discovery API specifications, affecting Chat, Classroom, Drive, Events, Gmail, and Sheets. Key updates include new methods for Chat and Drive, and updated documentation across several services. Feedback identifies an inconsistency in the Sheets --range flag default value documentation and the use of internal API names instead of CLI command names in the Classroom skill.
| | `--values` | — | — | Comma-separated values (simple strings) | | ||
| | `--json-values` | — | — | JSON array of rows, e.g. '[["a","b"],["c","d"]]' | | ||
| | `--range` | — | `A1` | Target range in A1 notation (e.g. 'Sheet2!A1') to select a specific tab | | ||
| | `--range` | — | — | Target range in A1 notation (e.g. 'Sheet2!A1'). Defaults to 'A1' (first sheet) | |
There was a problem hiding this comment.
The documentation for the --range flag is inconsistent. The "Default" column is empty (—), but the description states "Defaults to 'A1'". This inconsistency can confuse users and LLMs consuming this skill. The default value should be placed in the designated "Default" column.
Example:
| `--range` | — | `A1` | Target range in A1 notation (e.g. 'Sheet2!A1'). || - `list` — Returns a list of courses that the requesting user is permitted to view, restricted to those that match the request. Returned courses are ordered by creation time, with the most recently created coming first. This method returns the following error codes: * `PERMISSION_DENIED` for access errors. * `INVALID_ARGUMENT` if the query argument is malformed. * `NOT_FOUND` if any users specified in the query arguments do not exist. | ||
| - `patch` — Updates one or more fields in a course. This method returns the following error codes: * `PERMISSION_DENIED` if the requesting user is not permitted to modify the requested course or for access errors. * `NOT_FOUND` if no course exists with the requested ID. * `INVALID_ARGUMENT` if invalid fields are specified in the update mask or if no update mask is supplied. | ||
| - `update` — Updates a course. This method returns the following error codes: * `PERMISSION_DENIED` if the requesting user is not permitted to modify the requested course or for access errors. * `NOT_FOUND` if no course exists with the requested ID. * `FAILED_PRECONDITION` for the following request errors: * CourseNotModifiable * CourseTitleCannotContainUrl | ||
| - `update` — Updates a course. Note: Unlike other fields, `levels` is not cleared if omitted from the request. The `UpdateCourse` method only modifies `levels` if it is explicitly provided; otherwise, the existing value is preserved. Use the `PatchCourse` method to clear the `levels` field. This method returns the following error codes: * `PERMISSION_DENIED` if the requesting user is not permitted to modify the requested course or for access errors. * `NOT_FOUND` if no course exists with the requested ID. |
There was a problem hiding this comment.
The description for the update method refers to internal API method names (UpdateCourse, PatchCourse) which do not exist in the CLI. This can mislead users and LLMs. The text should be adjusted to refer to the CLI commands update and patch.
Example:
- `update` — Updates a course. Note: Unlike other fields, `levels` is not cleared if omitted from the request. The `update` command only modifies `levels` if it is explicitly provided; otherwise, the existing value is preserved. Use the `patch` command to clear the `levels` field. ...|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request synchronizes generated skills with the latest Google Discovery API specifications across several Google Workspace services. Key changes include the addition of the findGroupChats method in Chat, a comprehensive set of approval-related methods in Drive, and the generateCseToken method for Drive files. Additionally, documentation and method descriptions were updated for Classroom, Events, Gmail, and Sheets to provide better clarity and links to official guides. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for several Google Workspace skills—including Chat, Drive, Events, Gmail, and Sheets—to align with the latest Google Discovery API specifications. Key updates include the addition of the findGroupChats method in Chat, a comprehensive set of approval-related methods and the generateCseToken method in Drive, and enhanced descriptions with documentation links across multiple services. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for several Google Workspace skills to align with the latest Google Discovery API specifications. Key changes include adding the findGroupChats method to Chat, expanding the approvals and files resource methods in Drive, and updating method descriptions for Classroom, Events, Gmail, and Sheets. I have no feedback to provide as there were no review comments.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for several Google Workspace skills (Chat, Classroom, Drive, Events, Gmail, and Sheets) to align with the latest Google Discovery API specifications. Key updates include the addition of new methods for Drive approvals and Chat group chats, as well as refined descriptions for Classroom course updates and Gmail push notifications. I have no feedback to provide.
Automated PR — the Google Discovery API specs have changed and the
generated skill files are out of date.
Created by the Generate Skills workflow (
generate-skills.yml).