Skip to content

feat(o11y): regenerate stubs with lro_stub_options enabled#5880

Open
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:chore-regenerate-stubs-lro-options
Open

feat(o11y): regenerate stubs with lro_stub_options enabled#5880
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:chore-regenerate-stubs-lro-options

Conversation

@haphungw

Copy link
Copy Markdown
Contributor

Regenerate all client stubs to include the LRO options parameters in the generated Stub trait methods.

@haphungw haphungw changed the title feat(o11y): regenerate stubs with lro_stub_options enabled feat(o11y): regenerate stubs with lro_stub_options enabled Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the generator configuration in librarian.yaml to enable LRO stub options and bumps the library version, resulting in regenerated client SDKs. These regenerated files introduce conditional support for unstable tracing (google_cloud_unstable_tracing) to record LRO polling attributes and propagate poller options. Additionally, several service READMEs are updated with descriptive overviews. The feedback highlights that the description_override for the google-cloud-longrunning crate was unintentionally removed in librarian.yaml and should be restored to preserve crates.io metadata and historical context.

Comment thread librarian.yaml
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.87%. Comparing base (3185f7a) to head (219d0e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5880      +/-   ##
==========================================
- Coverage   97.88%   97.87%   -0.01%     
==========================================
  Files         230      230              
  Lines       58106    58106              
==========================================
- Hits        56877    56874       -3     
- Misses       1229     1232       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw force-pushed the chore-regenerate-stubs-lro-options branch from eefa798 to 219d0e7 Compare June 12, 2026 20:44
@haphungw haphungw marked this pull request as ready for review June 12, 2026 20:45
@haphungw haphungw requested review from a team as code owners June 12, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant