feat(storage): add deleteSourceObjects option to Bucket::compose()#9211
Open
salilg-eng wants to merge 5 commits into
Open
feat(storage): add deleteSourceObjects option to Bucket::compose()#9211salilg-eng wants to merge 5 commits into
salilg-eng wants to merge 5 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
deleteSourceObjectsoption (boolean) to theBucket::compose()method. When set totrue, the library takes care of auto-deleting the source objects immediately and safely following a successful composition.Transaction Safe: Cleanup is only triggered if composition succeeds. If composition fails and throws a
ServiceException, the source files are safely preserved.Polymorphic Handling: The deletion loop correctly handles lists containing both plain string paths (
string[]) and typedStorageObjectinstances.API Definition Consistency:
deleteSourceObjectsis added as a schema query parameter in the API Service Definition (storage-v1.json), ensuring consistent serialization down to the REST connection level.