chore: release test-release-please#8309
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates versions and dependencies across multiple Google Cloud Node.js packages, including upgrading sinon to 21.0.3 and adding overrides for @sinonjs/fake-timers. It also introduces new packages for appoptimize, databasecenter, and datacatalog-lineage-configmanagement. The reviewer identified that @types/sinon is redundant for sinon@21+ and should be removed from several package.json files. Furthermore, the reviewer noted that the test script in google-cloud-discoveryengine may cause redundant test execution on failure due to the shell command logic.
| "devDependencies": { | ||
| "@types/mocha": "^10.0.10", | ||
| "@types/node": "^22.13.9", | ||
| "@types/sinon": "^17.0.4", |
There was a problem hiding this comment.
The sinon package version 18 and above includes its own TypeScript definitions. Since you are using sinon@21.0.3, the @types/sinon dependency is no longer necessary and should be removed. The current version ^17.0.4 is for an older major version of sinon and will cause type conflicts.
| "devDependencies": { | ||
| "@types/mocha": "^10.0.10", | ||
| "@types/node": "^22.13.9", | ||
| "@types/sinon": "^17.0.4", |
There was a problem hiding this comment.
The sinon package version 18 and above includes its own TypeScript definitions. Since you are using sinon@21.0.3, the @types/sinon dependency is no longer necessary and should be removed. The current version ^17.0.4 is for an older major version of sinon and will cause type conflicts.
| "devDependencies": { | ||
| "@types/mocha": "^10.0.10", | ||
| "@types/node": "^22.13.9", | ||
| "@types/sinon": "^17.0.4", |
There was a problem hiding this comment.
The sinon package version 18 and above includes its own TypeScript definitions. Since you are using sinon@^21.0.0, the @types/sinon dependency is no longer necessary and should be removed. The current version ^17.0.4 is for an older major version of sinon and will cause type conflicts.
| "devDependencies": { | ||
| "@types/mocha": "^10.0.10", | ||
| "@types/node": "^22.13.9", | ||
| "@types/sinon": "^17.0.4", |
There was a problem hiding this comment.
The sinon package version 18 and above includes its own TypeScript definitions. Since you are using sinon@21.0.3, the @types/sinon dependency is no longer necessary and should be removed. The current version ^17.0.4 is for an older major version of sinon and will cause type conflicts.
| "samples-test": "cd samples/ && npm link ../ && npm i && npm test", | ||
| "system-test": "c8 mocha build/system-test", | ||
| "test": "NODE_OPTIONS=--max-old-space-size=16384 c8 mocha build/test" | ||
| "test": "NODE_OPTIONS=--max-old-space-size=16384 c8 mocha build/test || set NODE_OPTIONS=--max-old-space-size=16384 && c8 mocha build/test" |
There was a problem hiding this comment.
This script for running tests appears to be a workaround for cross-platform compatibility. However, on Unix-like systems, the use of || will cause the test suite to run a second time if it fails on the first attempt. This is likely not the intended behavior and could lead to confusing test logs and CI results.
1 participant
This release is too large to preview in the pull request body. View the full release notes here: https://github.com/googleapis/google-cloud-node/blob/release-please--branches--test-release-please--release-notes/release-notes.md