Skip to content

Fix npm audit vulnerabilities#1432

Merged
aomarks merged 1 commit into
google:mainfrom
bennypowers:fix/npm-audit-vulnerabilities
Jun 12, 2026
Merged

Fix npm audit vulnerabilities#1432
aomarks merged 1 commit into
google:mainfrom
bennypowers:fix/npm-audit-vulnerabilities

Conversation

@bennypowers

Copy link
Copy Markdown
Contributor

Summary

  • Bump brace-expansion from ^4.0.1 to ^5.0.6 to fix GHSA-f886-m6hf-6m8v (zero-step sequence causes process hang and memory exhaustion)
  • Update import in src/util/glob.ts from default export to named expand export (v5 breaking change)
  • Remove @types/brace-expansion (v5 ships its own type declarations)
  • Run npm audit fix to resolve 16 additional transitive devDependency vulnerabilities (ajv, fast-uri, flatted, lodash, markdown-it, minimatch, picomatch, pnpm, qs, tmp, underscore, undici, uuid, and related packages)

Details

Before: 18 vulnerabilities (8 moderate, 10 high)
After: 2 moderate (both from the published wireit@0.14.12 devDependency, which self-resolves on next publish)

No public API changes. Engine requirements unchanged (node >=18.0.0).

Test plan

  • tsc --noEmit passes
  • 24/25 tests pass (1 pre-existing flaky timeout in "caching with service dependencies works in watch mode")
  • npm audit shows only the self-referential devDependency vuln

Bump brace-expansion from ^4.0.1 to ^5.0.6 to address GHSA-f886-m6hf-6m8v
(zero-step sequence causes process hang and memory exhaustion). v5 changed
from a default export to a named `expand` export, so update the import in
src/util/glob.ts accordingly. Remove @types/brace-expansion since v5 ships
its own type declarations.

Run `npm audit fix` to address 16 additional vulnerabilities in transitive
devDependencies: ajv, fast-uri, flatted, lodash, markdown-it, minimatch,
picomatch, pnpm, qs, tmp, underscore, undici, uuid, and related packages.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@aomarks aomarks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aomarks aomarks merged commit e4bb9e2 into google:main Jun 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants