feat: use shared temporary directory for vanir signature generation#5234
Open
cuixq wants to merge 4 commits intogoogle:masterfrom
Open
feat: use shared temporary directory for vanir signature generation#5234cuixq wants to merge 4 commits intogoogle:masterfrom
cuixq wants to merge 4 commits intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4611
This PR updates the vanir_signatures worker to use a shared temporary directory for all Git-related operations during signature generation.
tempfile.TemporaryDirectoryis initialized and this path is passed down throughprocess_batchto_generate_vanir_signatures_batch.code_extractor_base.ExtractorConfigto explicitly setgit_working_dir, ensuring all signature generation threads share the same base directory.ExtractorConfigandgit_working_dirparameters.By using a shared working directory, the same repository does not need to be re-cloned if it contains multiple vulnerabilities. We may integrate gitter in a later PR to handle cloning repositories to the shared temp directory to further optimize the code extraction.