fix out-of-bounds read in EXR extra-channel row copy#233
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DecodeImageEXR (lib/extras/dec/exr.cc) the extra-channel copy reads from the input_extra_rows scratch buffer using ec.stride, which is the display-window-wide output stride, but that buffer is filled by the OpenEXR framebuffer with the data-window row stride pixel_stride*row_size (row_size = dataWindow.size().x + 1). When displayWindow is wider than dataWindow the source pointer runs past the populated rows and reads out of bounds, copying heap data into the decoded extra channels. The color copy just above already uses the data-window stride; this makes the extra-channel source match.