Fix missing boundary validation in Go Table.VectorLen#9146
Open
owvr27 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces missing boundary verification within the Go runtime implementation (
go/table.go), specifically targeting theTable.VectorLenfunction.Technical Details
Prior to this patch,
VectorLenexecuted offset increments and direct array slicing (t.Bytes[off:]) without verifying constraints againstlen(t.Bytes). This introduced an architectural consistency gap compared to safe functions likeByteVector. Processing a malformed or truncated binary payload would immediately trigger an unhandledslice bounds out of rangeruntime panic, resulting in a Remote Denial of Service (DoS) for downstream Go services.This fix applies identical rigid guards as
ByteVector, safely returning0when encountering invalid offsets while preserving FlatBuffers' zero-allocation design. All native test suites passed successfully via GoTest.sh.