feat: add idleShutdownMinutes setting to auto-quit CLI after inactivity#25212
feat: add idleShutdownMinutes setting to auto-quit CLI after inactivity#25212micahasmith wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an idle shutdown feature for the CLI to help manage memory usage over long periods of inactivity. By allowing users to define a timeout period, the application can now automatically terminate when not in use, preventing context bloat and excessive resource consumption. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an idle shutdown feature to the CLI, allowing the application to automatically close after a specified period of inactivity. The changes include adding a new configuration setting, general.idleShutdownMinutes, updating the settings schema and documentation, and implementing the timeout logic within the AppContainer component. Additionally, comprehensive unit tests were added to verify that the shutdown is triggered correctly and that the idle timer resets when the streaming state changes. I have no feedback to provide.
Agent-Logs-Url: https://github.com/micahasmith/gemini-cli/sessions/d2d149f9-e8ca-41e6-9ab5-d06da9f4c57f docs: add idleShutdownMinutes to settings and configuration reference Agent-Logs-Url: https://github.com/micahasmith/gemini-cli/sessions/a6d8690f-d25d-4b80-845d-3b20256c1c7f
Summary
closes #25211
Details
I use gemini-cli all day long. I've noticed that if i step away from the cli (hours) the memory usage blows up to the point that when i return i can neither
/compressnor make any prompt/requests due to the context now being too large for the API.Related Issues
closes #25211
How to Validate
Pre-Merge Checklist