Skip to content

Update NPM packages to resolve vulnerabilities#490

Merged
szczys merged 7 commits into
mainfrom
szczys/npm-package-update
May 29, 2026
Merged

Update NPM packages to resolve vulnerabilities#490
szczys merged 7 commits into
mainfrom
szczys/npm-package-update

Conversation

@szczys
Copy link
Copy Markdown
Collaborator

@szczys szczys commented May 29, 2026

  • Update NPM packages
  • Remove unused dependencies
  • Fix broken links

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Visit the preview URL for this PR (updated for commit 2db63ea):

https://golioth-docs-dev--pr490-szczys-npm-package-u-pe4ts1oh.web.app

(expires Sun, 28 Jun 2026 19:39:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f53b02bdc98ce6f5593931ec4c339aa96bac84df

Copy link
Copy Markdown
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szczys! Can we also update workflows to use npm ci rather than npm install to ensure we are installing the exact dependencies specified in our lockfile (example:

run: npm install && npm run build:dev
)

@szczys szczys requested a review from hasheddan May 29, 2026 19:39
@szczys
Copy link
Copy Markdown
Collaborator Author

szczys commented May 29, 2026

Thanks @szczys! Can we also update workflows to use npm ci rather than npm install to ensure we are installing the exact dependencies specified in our lockfile

Good guidance, thanks! I also took this opportunity to:

  • Update all github actions and pin them using a hash instead of a version
  • Update to the most recent npm LTS

Copy link
Copy Markdown
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @szczys 🙌🏻

@szczys szczys merged commit c83e915 into main May 29, 2026
2 checks passed
@szczys szczys deleted the szczys/npm-package-update branch May 29, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants