test: cover hidden files in optimized and fallback source globs#2918
Draft
Napolitain wants to merge 1 commit into
Draft
test: cover hidden files in optimized and fallback source globs#2918Napolitain wants to merge 1 commit into
Napolitain wants to merge 1 commit into
Conversation
Contributor
Author
|
The behavior choice I would like input on is whether My preference is to include them. A leading dot does not mean that a file is The draft is intentionally red and keeps production code unchanged while that |
Contributor
Author
|
@andreynering hey, note that the tests fail on purpose. While I am in favor of matching dotfiles via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2917.
This draft adds tests for recursive source globbing and fingerprint caching
through both the optimized and fallback paths.
add tests for :
**fallback patterns;
The tests propose that source globs include hidden entries consistently. They
currently demonstrate the mismatch on
main: optimized cases pass, whilefallback inclusions omit hidden inputs and fallback exclusions fail to remove
hidden inputs found by an optimized inclusion.
This PR intentionally changes no production behavior and is not merge-ready.
It is a tests-only draft intended to make the inconsistency and its cache impact
concrete while we decide between preserving the historical shell behavior or
adopting consistent hidden-entry inclusion.
Validation:
golangci-lint runpasses with no issues.go test ./internal/fsext -count=1passes.go test ./... -count=1fails intentionally only in the new fallbackexpectations under
internal/fingerprint.DotGlobtemporarily makes the new fingerprint and filesystem testspass; that production change is deliberately not included here.
AI assistance: I used Codex to help develop and validate these tests. I reviewed
and understand the changes.