Skip to content

[WIP] Fix failing GitHub Actions job Test (windows-latest) #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −12
Draft

[WIP] Fix failing GitHub Actions job Test (windows-latest) #4454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a08341
Initial plan
Copilot Jul 14, 2026
09abf51
Stabilize Windows query history selection test
Copilot Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions ...ions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,9 +363,11 @@ describe("QueryHistoryManager", () => {
});

// should be selected
expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
selected,
);
expect(
(
queryHistoryManager.treeDataProvider.getCurrent() as VariantAnalysisHistoryItem
).variantAnalysis.id,
).toBe(selected.variantAnalysis.id);
});

it("should remove the item", async () => {
Expand All @@ -384,9 +386,11 @@ describe("QueryHistoryManager", () => {
// remove an item
await queryHistoryManager.handleRemoveHistoryItem([toDelete]);

expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
selected,
);
expect(
(
queryHistoryManager.treeDataProvider.getCurrent() as VariantAnalysisHistoryItem
).variantAnalysis.id,
).toBe(selected.variantAnalysis.id);
expect(variantAnalysisManagerStub.showView).toHaveBeenCalledWith(
selected.variantAnalysis.id,
);
Expand Down Expand Up @@ -505,9 +509,11 @@ describe("QueryHistoryManager", () => {
});

// should be selected
expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
selected,
);
expect(
(
queryHistoryManager.treeDataProvider.getCurrent() as VariantAnalysisHistoryItem
).variantAnalysis.id,
).toBe(selected.variantAnalysis.id);

// remove an item
await queryHistoryManager.handleRemoveHistoryItem([toDelete]);
Expand All @@ -523,9 +529,11 @@ describe("QueryHistoryManager", () => {
});

it("should not change the selection", () => {
expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
selected,
);
expect(
(
queryHistoryManager.treeDataProvider.getCurrent() as VariantAnalysisHistoryItem
).variantAnalysis.id,
).toBe(selected.variantAnalysis.id);
expect(variantAnalysisManagerStub.showView).toHaveBeenCalledWith(
selected.variantAnalysis.id,
);
Expand Down