feat(extensions): port git extension scripts to Python by marcelsafin · Pull Request #3400 · github/spec-kit

marcelsafin · 2026-07-07T20:28:17Z

Summary

Fixes #3282 — part of #3277. Last script port in the porting phase: extensions/git/scripts/{bash,powershell}/ now has Python twins in extensions/git/scripts/python/.

Changes

git_common.py — has_git, effective_branch_name, check_feature_branch (port of git-common.sh)
initialize_repo.py — repo init with configurable initial commit message
auto_commit.py — per-event auto-commit, mirroring the line-based git-config.yml parser including the default/explicit-false precedence rules
create_new_feature_branch.py — full port: slug generation with stop-word filtering and acronym handling, sequential numbering across specs/local branches/remote refs, branch_template/branch_prefix with scoped numbering, GIT_BRANCH_NAME override, 244-byte truncation, SPECIFY_INIT_DIR via the core common.py resolver (same refusal as bash when core scripts are missing)

Same conventions as the merged check-prerequisites PoC and the #3280/#3281 ports: stdlib only, standalone scripts, no runtime wiring changes.

Testing

43 new tests in tests/extensions/git/test_git_extension_python_parity.py. The parity tests run each bash script and its Python twin in identical twin projects and assert matching stdout, exit codes, stderr, and resulting git state (branches created, commit messages). Covers branch creation and commit behavior per the issue's acceptance criteria, plus template validation errors, existing-branch handling, and no-git degradation.

uv run pytest tests/extensions/git/ — 97 passed
Full suite: 3847 passed, 105 skipped
uvx ruff check — clean

Checklist

Tests pass locally
Lint passes
I did use AI assistance for this contribution

Ports git-common, initialize-repo, auto-commit, and create-new-feature-branch to extensions/git/scripts/python/, mirroring the bash/PowerShell twins. Parity tests run each bash script and its Python twin in identical projects and compare output, exit codes, and resulting git state. Fixes github#3282 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR adds Python equivalents for the extensions/git workflow scripts, aiming to preserve behavior while reducing dual-maintenance across bash/PowerShell. It also introduces a parity-focused test suite to validate the Python ports against the existing bash implementations.

Changes:

Added Python ports for create-new-feature-branch, initialize-repo, auto-commit, and shared git helpers.
Introduced a parity test suite that runs bash vs Python “twin projects” and compares outcomes.
Added unit tests for git_common.py helper behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/extensions/git/test_git_extension_python_parity.py	Adds parity tests (bash vs Python) plus unit tests for `git_common.py`.
extensions/git/scripts/python/git_common.py	Implements git detection + feature-branch validation helpers.
extensions/git/scripts/python/initialize_repo.py	Initializes a repo and makes an initial commit using optional config-driven message.
extensions/git/scripts/python/auto_commit.py	Parses `git-config.yml` auto-commit settings and commits changes per event.
extensions/git/scripts/python/create_new_feature_branch.py	Implements feature-branch naming/numbering/template logic and branch creation, mirroring bash behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 5/5 changed files
Comments generated: 2
Review effort level: Low

An unreadable config file raised OSError with a full traceback from _parse_auto_commit_config. Treat it like a missing config: auto-commit stays disabled. Covered by a chmod-000 test (skipped on non-POSIX and as root). _assert_parity now also compares stderr so warning or usage-text regressions between the bash and Python twins fail the suite. All existing parity tests pass with the stricter assertion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Copilot

Review details

Files reviewed: 5/5 changed files
Comments generated: 1
Review effort level: Low

…utside-repo callers Without script_file, core.get_repo_root() falls back to Path.cwd() when SPECIFY_INIT_DIR is unset and no .specify root is found upward — the bash twin instead falls back to the script's install location (.specify/scripts/...). Pass script_file so both twins resolve the same repo_root; TypeError fallback keeps older cores working. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Copilot

Review details

Files reviewed: 5/5 changed files
Comments generated: 2
Review effort level: Low

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

…back - Catch (OSError, UnicodeDecodeError) when reading git-config.yml in create_new_feature_branch.py, initialize_repo.py, and auto_commit.py so invalid UTF-8 config falls back to defaults instead of crashing with a traceback. - Fall back to USERNAME (then "unknown") when USER is unset when deriving the branch author token, matching the PowerShell twin's Windows-friendly fallback chain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-14T13:02:31Z

@copilot review

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-14T13:35:08Z

@copilot review

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-14T13:44:54Z

@copilot review

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-14T13:57:09Z

@copilot review

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-14T14:09:01Z

@copilot review

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Copilot

Review details

Files reviewed: 7/7 changed files
Comments generated: 0 new
Review effort level: Low

mnriem · 2026-07-14T14:56:16Z

Thank you!

Copilot AI review requested due to automatic review settings July 7, 2026 20:28

marcelsafin requested a review from mnriem as a code owner July 7, 2026 20:28

Copilot started reviewing on behalf of marcelsafin July 7, 2026 20:28 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread extensions/git/scripts/python/create_new_feature_branch.py

Comment thread extensions/git/scripts/python/create_new_feature_branch.py Outdated

Comment thread tests/extensions/git/test_git_extension_python_parity.py

fix: match bash error message for whitespace-only descriptions

ee4f9c8

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin mentioned this pull request Jul 8, 2026

Add py: lines to command templates' scripts: frontmatter #3283

Closed

mnriem requested a review from Copilot July 8, 2026 13:40

Copilot started reviewing on behalf of mnriem July 8, 2026 13:41 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread tests/extensions/git/test_git_extension_python_parity.py

Comment thread extensions/git/scripts/python/auto_commit.py Outdated

Copilot AI review requested due to automatic review settings July 8, 2026 19:12

Copilot started reviewing on behalf of marcelsafin July 8, 2026 19:13 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

mnriem requested a review from Copilot July 9, 2026 18:04

Copilot started reviewing on behalf of mnriem July 9, 2026 18:05 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread extensions/git/scripts/python/create_new_feature_branch.py

Copilot AI review requested due to automatic review settings July 10, 2026 06:25

Copilot started reviewing on behalf of marcelsafin July 10, 2026 06:31 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

mnriem requested a review from Copilot July 10, 2026 14:20

Copilot started reviewing on behalf of mnriem July 10, 2026 14:20 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread tests/extensions/git/test_git_extension_python_parity.py Outdated

Comment thread tests/extensions/git/test_git_extension_python_parity.py Outdated

test: exercise SPECIFY_INIT_DIR from outside the project

8b3cc64

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 10, 2026 18:01

Copilot started reviewing on behalf of marcelsafin July 10, 2026 18:02 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread extensions/git/scripts/python/create_new_feature_branch.py Outdated

Comment thread extensions/git/scripts/python/create_new_feature_branch.py

Comment thread extensions/git/scripts/python/initialize_repo.py

Comment thread extensions/git/scripts/python/auto_commit.py

Copilot AI review requested due to automatic review settings July 10, 2026 20:21

Copilot started reviewing on behalf of marcelsafin July 14, 2026 13:02 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread extensions/git/scripts/python/auto_commit.py Outdated

fix(git): ignore unterminated config record

d2b0428

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 14, 2026 13:35

Copilot started reviewing on behalf of marcelsafin July 14, 2026 13:35 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread tests/extensions/git/test_git_extension_python_parity.py

test(git): handle Windows persist hint parity

8e1c3cf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 14, 2026 13:44

Copilot started reviewing on behalf of marcelsafin July 14, 2026 13:45 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread tests/extensions/git/test_git_extension_python_parity.py Outdated

fix(init): install Python shared scripts

0a9de25

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 14, 2026 13:56

Copilot started reviewing on behalf of marcelsafin July 14, 2026 13:57 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread tests/extensions/git/test_git_extension_python_parity.py

test(git): normalize Windows persistence hints

55c4398

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 14, 2026 14:08

Copilot started reviewing on behalf of marcelsafin July 14, 2026 14:09 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

mnriem requested a review from Copilot July 14, 2026 14:43

Copilot started reviewing on behalf of mnriem July 14, 2026 14:44 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

mnriem self-requested a review July 14, 2026 14:55

mnriem approved these changes Jul 14, 2026

View reviewed changes

mnriem merged commit 91839fb into github:main Jul 14, 2026
12 checks passed

Uh oh!

Conversation

marcelsafin commented Jul 7, 2026

Summary

Changes

Testing

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcelsafin commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

marcelsafin commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

marcelsafin commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

marcelsafin commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

marcelsafin commented Jul 14, 2026

Uh oh!

Copilot AI left a comment