enforce: add stringsindexcontains + stringscountcontains to CI linter batch

[Copilot]

Two strings.Contains-simplification linters (stringsindexcontains, stringscountcontains) were fully implemented and test-verified but absent from the CI enforcement gate.

Changes

• pkg/cli/compile_update_check.go — Fix the single blocking stringscountcontains violation:

  // before
  return strings.Count(core, ".") >= 1
  // after
  return strings.Contains(core, ".")

• .github/workflows/cgo.yml — Append -stringsindexcontains -stringscountcontains to LINTER_FLAGS in both the default and GOOS=js GOARCH=wasm custom-linter invocations (lines 1208 & 1211).

[Copilot]

Pull request overview

Enforces two existing strings.Contains simplification analyzers in CI.

Changes:

• Replaces a flagged strings.Count check with strings.Contains.
• Enables both analyzers for default and WebAssembly lint runs.

Show a summary per file

File	Description
pkg/cli/compile_update_check.go	Simplifies explicit minor-version detection.
.github/workflows/cgo.yml	Adds both analyzers to CI lint flags.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium

[gh-aw-bot]

pr-sous-chef
@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29325358083

Generated by 👨‍🍳 PR Sous Chef · 5.27 AIC · ⌖ 7.39 AIC · ⊞ 5.1K · ◷
_{Comment /souschef to run again}

[Copilot]

pr-sous-chef
@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.
...

Ran pr-finisher. Here's the status:

• ✅ Reviews — No unresolved review threads. The Copilot reviewer left no actionable comments.
• ✅ Checks (local) — make fmt, make lint, and make test-unit all pass cleanly.
• ❓ Checks (CI) — Stale after agent push; needs human re-trigger. Prior CI run (29319142785) completed with all jobs green: lint-go, test, build, build-wasm, canary-go, Windows Integration, Build & Test on macos-latest — all success.
• ✅ Mergeable — PR is open, not draft, branch is up to date with base (d1bc039), no conflicts.

Actions taken: No code changes needed — the branch was already in a merge-ready state.

Hand-off: CI must be re-triggered by a maintainer (close/reopen PR, workflow_dispatch, or a push) before merge.