java: enforce non-blank @CopilotToolParam description at compile time#1980
Open
rinceyuan wants to merge 1 commit into
Open
java: enforce non-blank @CopilotToolParam description at compile time#1980rinceyuan wants to merge 1 commit into
rinceyuan wants to merge 1 commit into
Conversation
Closes github#1836 Add compile-time validation in CopilotToolProcessor to reject @CopilotToolParam annotations with blank value (description). - Blank or whitespace-only descriptions now produce a compile error - Single-record wrapper parameters are exempt (they delegate to record component annotations) - Error message identifies parameter name, method, and class - 5 new tests covering blank, whitespace, valid, unannotated, and record-wrapper cases
Contributor
Author
|
@microsoft-github-policy-service agree company=Microsoft |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1836
Summary
Adds compile-time validation in
CopilotToolProcessorto reject@CopilotToolParamannotations with blankvalue()(description). Without a meaningful description, the LLM cannot reliably select and invoke tools.Changes
CopilotToolProcessor.javaparamAnnotation.value().isBlank()(catches both empty and whitespace-only)CopilotToolProcessorTest.java(5 new tests)@CopilotToolParam("")produces compile error@CopilotToolParam(" ")produces compile error@CopilotToolParam("Search query")compiles without error@CopilotToolParamon single-record wrapper is exemptError message example
Testing
mvn test -Dtest=CopilotToolProcessorTest— 39 tests pass (0 failures)mvn verifywith JDK 25+