C++: Remove deprecated code deprecated more than a year ago#21709
Merged
jketema merged 2 commits intogithub:mainfrom Apr 14, 2026
Merged
C++: Remove deprecated code deprecated more than a year ago#21709jketema merged 2 commits intogithub:mainfrom
jketema merged 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes long-deprecated C++ CodeQL modeling interfaces (ThrowingFunction and NonThrowingFunction) and adds a breaking change note documenting the migration paths.
Changes:
- Removed deprecated
ThrowingFunctioninterface fromThrowing.qll. - Removed deprecated
NonThrowingFunctionalias fromNonThrowing.qll. - Added a breaking change note describing the removals and replacements.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/models/interfaces/Throwing.qll | Removes deprecated ThrowingFunction API. |
| cpp/ql/lib/semmle/code/cpp/models/interfaces/NonThrowing.qll | Removes deprecated NonThrowingFunction alias. |
| cpp/ql/lib/change-notes/2026-04-14-throwing.md | Documents the breaking removals and migration targets. |
Copilot's findings
Comments suppressed due to low confidence (1)
cpp/ql/lib/semmle/code/cpp/models/interfaces/Throwing.qll:16
- The module-level documentation at the top of this file still instructs users to extend
ThrowingFunction, butThrowingFunctionis removed in this PR. Please update the header comment to reference the current API (likelyAlwaysSehThrowingFunction) and adjust the description accordingly so it no longer claims to model generic “may throw” behavior if the module now only exposes SEH-throwing behavior.
/**
* A function that unconditionally raises a structured exception handling (SEH) exception.
*/
abstract class AlwaysSehThrowingFunction extends Function { }
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not need to run DCA on this; just piggy backing some DCA on this PR to test something.