common: use physical core count for --threads -1 default#23932
Open
Oxygen56 wants to merge 1 commit into
Open
Conversation
Replace std::thread::hardware_concurrency() with common_cpu_get_num_physical_cores() for the --threads -1 default value calculation. std::thread::hardware_concurrency() returns logical CPU count, which includes hyper-threads, causing --threads -1 to double-count on HT-enabled systems. common_cpu_get_num_physical_cores() already exists in common.cpp and returns the correct physical core count. Fixes ggml-org#19110 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
std::thread::hardware_concurrency()withcommon_cpu_get_num_physical_cores()for the--threads -1default value calculation.std::thread::hardware_concurrency()returns logical CPU count, which includes hyper-threads, causing--threads -1to double-count on HT-enabled systems.common_cpu_get_num_physical_cores()already exists incommon/common.cppand returns the correct physical core count.Fixes #19110